Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread Kevin A. McGrail
On 6/13/2019 1:13 PM, Henrik K wrote: > On Thu, Jun 13, 2019 at 12:59:16PM -0400, Kevin A. McGrail wrote: >> Just double checking since John mentioned the extra parens. > In this case.. too much parens.. qr_to_string was supposed to remove the > (?-xism:. > > We should really implement the

Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread Henrik K
On Thu, Jun 13, 2019 at 12:59:16PM -0400, Kevin A. McGrail wrote: > > Just double checking since John mentioned the extra parens. In this case.. too much parens.. qr_to_string was supposed to remove the (?-xism:. We should really implement the (apache infra provided?) CI service that would

Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread Kevin A. McGrail
On 6/13/2019 12:44 PM, Henrik K wrote: >> Henrik, your thoughts on this with the sa-compile changes?  The key >> point I need is should it block 3.4.3 or did you already fix it?  Or is >> it just a rule issue? > I thought it was already established that I fixed it and rc3 needs to > rolled. > Just

Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread Henrik K
On Thu, Jun 13, 2019 at 12:42:17PM -0400, Kevin A. McGrail wrote: > On 6/13/2019 11:33 AM, John Hardin wrote: > > On Thu, 13 Jun 2019, Kevin A. McGrail wrote: > > > >> While running sa-update, I noticed a number of lines about replace tag > >> compilation errors. > >> > >> Attached is an output

Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread Kevin A. McGrail
On 6/13/2019 11:33 AM, John Hardin wrote: > On Thu, 13 Jun 2019, Kevin A. McGrail wrote: > >> While running sa-update, I noticed a number of lines about replace tag >> compilation errors. >> >> Attached is an output from 3.4.2 and an output from 3.4.3. >> >> Henrik, any thoughts? > > It looks like

Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread John Hardin
On Thu, 13 Jun 2019, Kevin A. McGrail wrote: While running sa-update, I noticed a number of lines about replace tag compilation errors. Attached is an output from 3.4.2 and an output from 3.4.3. Henrik, any thoughts? It looks like appending another paren at the end of the entire RE would

Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3

2019-06-13 Thread John Hardin
On Thu, 13 Jun 2019, Kevin A. McGrail wrote: While running sa-update, I noticed a number of lines about replace tag compilation errors. Attached is an output from 3.4.2 and an output from 3.4.3. Doesn't happen on a trunk lint... ? -- John Hardin KA7OHZ