Re: Spark 3.2.0 first RC next week

2021-08-11 Thread Gengliang Wang
Thanks for your information, Sean and Min! On Tue, Aug 10, 2021 at 9:59 PM Min Shen wrote: > Hi Gengliang, > > SPARK-36378 (Switch to using RPCResponse to communicate common block push > failures to the client) should be another one. > This introduces a slight protocol change to push-based

Re: TreeNode.exists?

2021-08-11 Thread Sean Owen
If this is repeated a bunch of places in the code, sure, a utility method could be good. I think .find(x).isDefined is even not optimal - .exists(x) is a little easier and may be slightly faster? If you find a chance for refactoring, sure open a minor PR. On Wed, Aug 11, 2021 at 9:42 AM Jacek

TreeNode.exists?

2021-08-11 Thread Jacek Laskowski
Hi, It's been a couple of times already when I ran into a code like the following ([1]): val isCommand = plan.find { case _: Command | _: ParsedStatement | _: InsertIntoDir => true case _ => false }.isDefined I think that this and the other places beg (scream?) for