Re: KryoSerializer Implementation - Not using KryoPool

2018-10-25 Thread Patrick Brown
way > that breaks something. I see there's already a reset() call in here to > try to avoid that. > > Well, seems worth a PR, especially if you can demonstrate some > performance gains. > > On Wed, Oct 24, 2018 at 3:09 PM Patrick Brown > wrote: > > > > Hi, &g

KryoSerializer Implementation - Not using KryoPool

2018-10-24 Thread Patrick Brown
Hi, I am wondering about the implementation of KryoSerializer, specifically the lack of use of KryoPool, which is recommended by Kryo themselves. Looking at the code, it seems that frequently KryoSerializer.newInstance is called, followed by a serialize and then this instance goes out of scope,