I've created a PR to add the error message guidelines to the Spark
contributing guide. Would appreciate some eyes on it!
https://github.com/apache/spark-website/pull/332
On Wed, Apr 14, 2021 at 5:34 PM Yuming Wang wrote:
> +1 LGTM.
>
> On Thu, Apr 15, 2021 at 1:50 AM Karen wrote:
>
>> That make
+1 LGTM.
On Thu, Apr 15, 2021 at 1:50 AM Karen wrote:
> That makes sense to me - given that an assert failure throws an
> AssertException, I would say that the same guidelines should apply for
> asserts.
>
> On Tue, Apr 13, 2021 at 7:41 PM Yuming Wang wrote:
>
>> Do we have plans to apply these
That makes sense to me - given that an assert failure throws an
AssertException, I would say that the same guidelines should apply for
asserts.
On Tue, Apr 13, 2021 at 7:41 PM Yuming Wang wrote:
> Do we have plans to apply these guidelines to assert? For example:
>
>
> https://github.com/apache/
Do we have plans to apply these guidelines to assert? For example:
https://github.com/apache/spark/blob/5b478416f8e3fe2f015af1b6c8faa7fe9f15c05d/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala#L136-L138
https://github.com/apache/spark/blob/053dd858d38e6107bc71
I would just go ahead and create a PR for that. Nothing written there looks
unreasonable.
But probably it should be best to wait a couple of days to make sure people
are happy with it.
2021년 4월 14일 (수) 오전 6:38, Karen 님이 작성:
> If the proposed guidelines look good, it would be useful to share these
If the proposed guidelines look good, it would be useful to share these
guidelines with the wider community. A good landing page for contributors
could be https://spark.apache.org/contributing.html. What do you think?
Thank you,
Karen Feng
On Wed, Apr 7, 2021 at 8:19 PM Hyukjin Kwon wrote:
> L
LGTM (I took a look, and had some offline discussions w/ some corrections
before it came out)
2021년 4월 8일 (목) 오전 5:28, Karen 님이 작성:
> Hi all,
>
> As discussed in SPIP: Standardize Exception Messages in Spark (
> https://docs.google.com/document/d/1XGj1o3xAFh8BA7RCn3DtwIPC6--hIFOaNUNSlpaOIZs/edit?
Hi all,
As discussed in SPIP: Standardize Exception Messages in Spark (
https://docs.google.com/document/d/1XGj1o3xAFh8BA7RCn3DtwIPC6--hIFOaNUNSlpaOIZs/edit?usp=sharing),
improving error message quality in Apache Spark involves establishing an
error message guideline for developers. Error message
