On Thu, Nov 13, 2014 at 10:58 AM, Patrick Wendell wrote:
>> That's true, but note the code I posted activates a profile based on
>> the lack of a property being set, which is why it works. Granted, I
>> did not test that if you activate the other profile, the one with the
>> property check will be
> That's true, but note the code I posted activates a profile based on
> the lack of a property being set, which is why it works. Granted, I
> did not test that if you activate the other profile, the one with the
> property check will be disabled.
Ah yeah good call - I so then we'd trigger 2.11-vs
Hey Patrick,
On Thu, Nov 13, 2014 at 10:49 AM, Patrick Wendell wrote:
> I'm not sure chaining activation works like that. At least in my
> experience activation based on properties only works for properties
> explicitly specified at the command line rather than declared
> elsewhere in the pom.
T
Hey Marcelo,
I'm not sure chaining activation works like that. At least in my
experience activation based on properties only works for properties
explicitly specified at the command line rather than declared
elsewhere in the pom.
https://gist.github.com/pwendell/6834223e68f254e6945e
I any case,
https://github.com/apache/spark/pull/3239 addresses this
On Thu, Nov 13, 2014 at 10:05 AM, Marcelo Vanzin
wrote:
> Hello there,
>
> So I just took a quick look at the pom and I see two problems with it.
>
> - "activatedByDefault" does not work like you think it does. It only
> "activates by defa
Hello there,
So I just took a quick look at the pom and I see two problems with it.
- "activatedByDefault" does not work like you think it does. It only
"activates by default" if you do not explicitly activate other
profiles. So if you do "mvn package", scala-2.10 will be activated;
but if you do
I actually do agree with this - let's see if we can find a solution
that doesn't regress this behavior. Maybe we can simply move the one
kafka example into its own project instead of having it in the
examples project.
On Wed, Nov 12, 2014 at 11:07 PM, Sandy Ryza wrote:
> Currently there are no ma
Currently there are no mandatory profiles required to build Spark. I.e.
"mvn package" just works. It seems sad that we would need to break this.
On Wed, Nov 12, 2014 at 10:59 PM, Patrick Wendell
wrote:
> I think printing an error that says "-Pscala-2.10 must be enabled" is
> probably okay. It'
I think printing an error that says "-Pscala-2.10 must be enabled" is
probably okay. It's a slight regression but it's super obvious to
users. That could be a more elegant solution than the somewhat
complicated monstrosity I proposed on the JIRA.
On Wed, Nov 12, 2014 at 10:37 PM, Prashant Sharma
One thing we can do it is print a helpful error and break. I don't know
about how this can be done, but since now I can write groovy inside maven
build so we have more control. (Yay!!)
Prashant Sharma
On Thu, Nov 13, 2014 at 12:05 PM, Patrick Wendell
wrote:
> Yeah Sandy and I were chatting ab
Yeah Sandy and I were chatting about this today and din't realize
-Pscala-2.10 was mandatory. This is a fairly invasive change, so I was
thinking maybe we could try to remove that. Also if someone doesn't
give -Pscala-2.10 it fails in a way that is initially silent, which is
bad because most people
For scala 2.11.4, there are minor changes needed in repl code. I can do
that if that is a high priority.
Prashant Sharma
On Thu, Nov 13, 2014 at 11:59 AM, Prashant Sharma
wrote:
> Thanks Patrick, I have one suggestion that we should make passing
> -Pscala-2.10 mandatory for maven users. I am
Thanks Patrick, I have one suggestion that we should make passing
-Pscala-2.10 mandatory for maven users. I am sorry for not mentioning this
before. There is no way around not passing that option for maven
users(only). However, this is unnecessary for sbt users because it is added
automatically if
- Tip: when you rebase, IntelliJ will temporarily think things like the
Kafka module are being removed. Say 'no' when it asks if you want to remove
them.
- Can we go straight to Scala 2.11.4?
On Wed, Nov 12, 2014 at 5:47 AM, Patrick Wendell wrote:
> Hey All,
>
> I've just merged a patch that add
Hey All,
I've just merged a patch that adds support for Scala 2.11 which will
have some minor implications for the build. These are due to the
complexities of supporting two versions of Scala in a single project.
1. The JDBC server will now require a special flag to build
-Phive-thriftserver on t
15 matches
Mail list logo
