Re: [SQL] When SQLConf vals gets own accessor defs?

2021-09-06 Thread Wenchen Fan
I think SQLConf doesn't need defs anymore. In the beginning, SQLConf lived in sql/core, so we have to add defs if the code in sql/catalyst needs to access configs. Now SQLConf is in sql/catalyst (this was done a few years ago), defs are only needed if we have some special logic that is not just

[SQL] When SQLConf vals gets own accessor defs?

2021-09-03 Thread Jacek Laskowski
Hi, Just found something I'd consider an inconsistency in how SQLConf constants (vals) get their own accessor method for the current value (defs). I thought that internal config prop vals might not have defs (and that would make sense) but