Re: [YARN] Small fix for yarn.Client to use buildPath (not Path.SEPARATOR)

2016-06-15 Thread Steve Loughran
> On 14 Jun 2016, at 13:58, Jacek Laskowski wrote: > > Hi Steve and Sean, > > Didn't expect such a warm welcome from Sean and you! Since I'm with > Spark on YARN these days, let me see what I can do to make it nicer. > Thanks! > > I'm going to change Spark to use buildPath first. And then prop

Re: [YARN] Small fix for yarn.Client to use buildPath (not Path.SEPARATOR)

2016-06-14 Thread Jacek Laskowski
Hi Steve and Sean, Didn't expect such a warm welcome from Sean and you! Since I'm with Spark on YARN these days, let me see what I can do to make it nicer. Thanks! I'm going to change Spark to use buildPath first. And then propose another patch to use Environment.CLASS_PATH_SEPARATOR instead. And

Re: [YARN] Small fix for yarn.Client to use buildPath (not Path.SEPARATOR)

2016-06-14 Thread Steve Loughran
if you want to be able to build up CPs on windows to run on a Linux cluster, or vice-versa, you really need to be using the Environment.CLASS_PATH_SEPARATOR field, "". This is expanded in the cluster, not in the client Although tagged as @Public, @Unstable, it's been in there sinceYARN-1824 &

Re: [YARN] Small fix for yarn.Client to use buildPath (not Path.SEPARATOR)

2016-06-13 Thread Sean Owen
Yeah it does the same thing anyway. It's fine to consistently use the method. I think there's an instance in ClientSuite that can use it. On Mon, Jun 13, 2016 at 6:50 PM, Jacek Laskowski wrote: > Hi, > > Just noticed that yarn.Client#populateClasspath uses Path.SEPARATOR > [1] to build a CLASSPAT

[YARN] Small fix for yarn.Client to use buildPath (not Path.SEPARATOR)

2016-06-13 Thread Jacek Laskowski
Hi, Just noticed that yarn.Client#populateClasspath uses Path.SEPARATOR [1] to build a CLASSPATH entry while another similar-looking line uses buildPath method [2]. Could a pull request with a change to use buildPath at [1] be accepted? I'm always confused how to fix such small changes. [1] htt