This is now done with this pull request:
https://github.com/apache/spark/pull/8091
Committers please update the script to get this "feature".
On Mon, Jul 20, 2015 at 12:28 AM, Manoj Kumar <
manojkumarsivaraj...@gmail.com> wrote:
> +1
>
> Sounds like a great idea.
>
> On Sun, Jul 19, 2015 at 10
+1
Sounds like a great idea.
On Sun, Jul 19, 2015 at 10:54 PM, Sandy Ryza
wrote:
> +1
>
> On Sat, Jul 18, 2015 at 4:00 PM, Mridul Muralidharan
> wrote:
>
>> Thanks for detailing, definitely sounds better.
>> +1
>>
>> Regards
>> Mridul
>>
>> On Saturday, July 18, 2015, Reynold Xin wrote:
>>
>>
+1
On Sat, Jul 18, 2015 at 4:00 PM, Mridul Muralidharan
wrote:
> Thanks for detailing, definitely sounds better.
> +1
>
> Regards
> Mridul
>
> On Saturday, July 18, 2015, Reynold Xin wrote:
>
>> A single commit message consisting of:
>>
>> 1. Pull request title (which includes JIRA number and c
Thanks for detailing, definitely sounds better.
+1
Regards
Mridul
On Saturday, July 18, 2015, Reynold Xin wrote:
> A single commit message consisting of:
>
> 1. Pull request title (which includes JIRA number and component, e.g.
> [SPARK-1234][MLlib])
>
> 2. Pull request description
>
> 3. List
A single commit message consisting of:
1. Pull request title (which includes JIRA number and component, e.g.
[SPARK-1234][MLlib])
2. Pull request description
3. List of authors contributing to the patch
The main thing that changes is 3: we used to also include the individual
commits to the pull
Just to clarify, the proposal is to have a single commit msg giving the
jira and pr id?
That sounds like a good change to have.
Regards
Mridul
On Saturday, July 18, 2015, Reynold Xin wrote:
> I took a look at the commit messages in git log -- it looks like the
> individual commit messages are n
+1
Sent from my iPhone
> On Jul 18, 2015, at 2:44 PM, Patrick Wendell wrote:
>
> +1 from me too
>
>> On Sat, Jul 18, 2015 at 3:32 AM, Ted Yu wrote:
>> +1 to removing commit messages.
>>
>>
>>
>>> On Jul 18, 2015, at 1:35 AM, Sean Owen wrote:
>>>
>>> +1 to removing them. Sometimes there
+1 from me too
On Sat, Jul 18, 2015 at 3:32 AM, Ted Yu wrote:
> +1 to removing commit messages.
>
>
>
>> On Jul 18, 2015, at 1:35 AM, Sean Owen wrote:
>>
>> +1 to removing them. Sometimes there are 50+ commits because people
>> have been merging from master into their branch rather than rebasing
+1 to removing commit messages.
> On Jul 18, 2015, at 1:35 AM, Sean Owen wrote:
>
> +1 to removing them. Sometimes there are 50+ commits because people
> have been merging from master into their branch rather than rebasing.
>
>> On Sat, Jul 18, 2015 at 8:48 AM, Reynold Xin wrote:
>> I took
+1 to removing them. Sometimes there are 50+ commits because people
have been merging from master into their branch rather than rebasing.
On Sat, Jul 18, 2015 at 8:48 AM, Reynold Xin wrote:
> I took a look at the commit messages in git log -- it looks like the
> individual commit messages are not
I took a look at the commit messages in git log -- it looks like the
individual commit messages are not that useful to include, but do make the
commit messages more verbose. They are usually just a bunch of extremely
concise descriptions of "bug fixes", "merges", etc:
cb3f12d [xxx] add whitesp
11 matches
Mail list logo
