+1
On Fri, 25 Sep 2020, 02:21 Holden Karau, wrote:
> Thanks Shane!
>
> On Thu, Sep 24, 2020 at 10:17 AM shane knapp ☠
> wrote:
>
>> just revisiting this thread...
>>
>> re presubmit strategy: i don't think this would be easy to set up...
>> and i'm not sure what benefit it will give us.
>>
>>
Thanks Shane!
On Thu, Sep 24, 2020 at 10:17 AM shane knapp ☠ wrote:
> just revisiting this thread...
>
> re presubmit strategy: i don't think this would be easy to set up... and
> i'm not sure what benefit it will give us.
>
> re inadvertent errors: since we're checking out the same hash
just revisiting this thread...
re presubmit strategy: i don't think this would be easy to set up... and
i'm not sure what benefit it will give us.
re inadvertent errors: since we're checking out the same hash from the PR
for both builds, and they'll run simultaneously, i don't think it'll be
Sounds good, thanks for the heads up. I hope you get some time to relax :)
On Thu, Aug 20, 2020 at 2:26 PM shane knapp ☠ wrote:
> fyi, i won't be making this change until the 1st week of september. i'll
> be out, off the grid all next week! :)
>
> i will send an announcement out tomorrow on
fyi, i won't be making this change until the 1st week of september. i'll
be out, off the grid all next week! :)
i will send an announcement out tomorrow on how to contact my team here @
uc berkeley if jenkins goes down.
shane
On Thu, Aug 20, 2020 at 4:40 AM Prashant Sharma
wrote:
> Another
Another option is, if we could have something like "presubmit" PR build. In
other words, running the entire 4 H + K8s integration on each commit pushed
is too much at the same time and there are chances that one thing can
inadvertently affect other components(as you just said).
A presubmit(which
we'll be gated by the number of ubuntu workers w/minikube and docker, but
it shouldn't be too bad as the full integration test takes ~45m, vs 4+ hrs
for the regular PRB.
i can enable this in about 1m of time if the consensus is for us to want
this.
On Wed, Aug 19, 2020 at 11:37 AM Holden Karau
Sounds good. In the meantime would folks committing things in core run the
K8s PRB or run it locally? A second change this morning was committed that
broke the K8s PR tests.
On Tue, Aug 18, 2020 at 9:53 PM Prashant Sharma
wrote:
> +1, we should enable.
>
> On Wed, Aug 19, 2020 at 9:18 AM Holden
+1, we should enable.
On Wed, Aug 19, 2020 at 9:18 AM Holden Karau wrote:
> Hi Dev Folks,
>
> I was wondering how people feel about enabling the K8s PRB automatically
> for all core changes? Sometimes I forget that a change might impact one of
> the K8s integration tests since a bunch of them
yes, i think this is fine. the k8s prb runs concurrently to the regular
prb and takes ~20m.
On Tue, Aug 18, 2020 at 8:47 PM Holden Karau wrote:
> Hi Dev Folks,
>
> I was wondering how people feel about enabling the K8s PRB automatically
> for all core changes? Sometimes I forget that a change
10 matches
Mail list logo
