Re: Request review for long-standing PRs

2019-02-26 Thread Arun Mahadevan
Yes, I agree thats its a valid concern and leads to individual contributors giving up on new ideas or major improvements. On Tue, 26 Feb 2019 at 15:24, Jungtaek Lim wrote: > Adding one more, it implicitly leads individual contributors to give up > with challenging major things and just focus on

Re: Request review for long-standing PRs

2019-02-26 Thread Sean Owen
Mr Torres can you give these a pass please? On Tue, Feb 26, 2019 at 4:38 PM Jungtaek Lim wrote: > > Hi devs, > > sorry to bring this again to mailing list, but you know, ping in Github PR > just doesn't work. > > I have long-stand (created in last year) PRs on SS area which already got > over 1

Re: Request review for long-standing PRs

2019-02-26 Thread Jungtaek Lim
Adding one more, it implicitly leads individual contributors to give up with challenging major things and just focus on minor things, which would even help on project, but not in the long run. We don't have roadmap put into wall and let whole community share the load together, so individual contrib

Re: Request review for long-standing PRs

2019-02-26 Thread Jungtaek Lim
Thanks Sean, as always, to share your thought quickly! I agree most of points, except "they add a lot of code and complexity relative to benefit", since no one can weigh on something before at least taking quick review. IMHO if someone would think so, better to speak (I know it's hard and being a

Re: Request review for long-standing PRs

2019-02-26 Thread Sean Owen
Those aren't bad changes, but they add a lot of code and complexity relative to benefit. I think it's positive that you've gotten people to spend time reviewing them, quite a lot. I don't know whether they should be merged. This isn't a 'bug' though; not all changes should be committed. Simple and

Request review for long-standing PRs

2019-02-26 Thread Jungtaek Lim
Hi devs, sorry to bring this again to mailing list, but you know, ping in Github PR just doesn't work. I have long-stand (created in last year) PRs on SS area which already got over 100 comments (so community and me already put lots of efforts) but no progress in point of view for being merged un