Re: Review notification bot

(BTW, seems not turned off yet - https://github.com/apache/spark/pull/21939#issuecomment-409412805) 2018년 8월 1일 (수) 오전 2:24, Sean Owen 님이 작성: > I haven't been pinged by this bot :( :) > > But I do like this comments on PRs: like > https://github.com/apache/spark/pull/21925#issuecomment-409035244

Re: Review notification bot

I haven't been pinged by this bot :( :) But I do like this comments on PRs: like https://github.com/apache/spark/pull/21925#issuecomment-409035244 Is the issue that @-mentions cause emails too? Is there any option to maybe only consider pinging someone if they've touched the code within the

Re: Review notification bot

ng contributors to review the >>> codebase they know about. One thing which may be worth to also consider is, >>> in open source project, it is very common for individual to (implicitly or >>> explicitly) stop contributing the project for various reason, so conce

Re: Review notification bot

contributing the project for various reason, so concerning >> activeness (or date of commit) would be ideal. >> >> I admit above things might be ideal rather than realistic, but just think >> out loud to see review notification bot more useful for contributors and >>

Re: Review notification bot

(implicitly or > explicitly) stop contributing the project for various reason, so concerning > activeness (or date of commit) would be ideal. > > I admit above things might be ideal rather than realistic, but just think > out loud to see review notification bot more useful for contributors a

Re: Review notification bot

explicitly) stop contributing the project for various reason, so concerning activeness (or date of commit) would be ideal. I admit above things might be ideal rather than realistic, but just think out loud to see review notification bot more useful for contributors and less annoyed for someone. Thanks, Jun

Re: Review notification bot

Another thing we could try and do (if folks would be down to try) is it have not actually ping, but suggest the potential usernames to ping to the user (e.g. say suggested reviewers you _may wish to ping_ and then list)? On Mon, Jul 30, 2018 at 10:45 PM, Holden Karau wrote: > > On Mon, Jul 30,

Re: Review notification bot

On Mon, Jul 30, 2018 at 10:22 PM, Reynold Xin wrote: > I like the idea of this bot, but I'm somewhat annoyed by it. I have > touched a lot of files and wrote a lot of the original code. Everyday I > wake up I get a lot of emails from this bot. > We could blacklist the existing PMC (or add a rate

Re: Review notification bot

I like the idea of this bot, but I'm somewhat annoyed by it. I have touched a lot of files and wrote a lot of the original code. Everyday I wake up I get a lot of emails from this bot. Also if we are going to use this, can we rename the bot to something like spark-bot, rather than holden's

Re: Review notification bot

> That being said the folks being pinged are not just committers. I doubt it because only pinged ones I see are all committers and that's why I assumed the pinging is based on who committed the PR (which implies committer only). Do you maybe have some examples where non-committers were pinged?

Re: Review notification bot

So CODEOWNERS is limited to committers by GitHub. We can definitely modify the config file though and I'm happy to write some custom logic if it helps support our needs. We can also just turn it off if it's too noisey for folks in general. That being said the folks being pinged are not just

Re: Review notification bot

*reviewers: I mean people who committed the PR given my observation. 2018년 7월 31일 (화) 오전 11:50, Hyukjin Kwon 님이 작성: > I was wondering if we can leave the configuration open and accept some > custom configurations, IMHO, because I saw some people less related or less > active are consistently

Re: Review notification bot

I was wondering if we can leave the configuration open and accept some custom configurations, IMHO, because I saw some people less related or less active are consistently pinged. Just started to get worried if they get annoyed by this. Also, some people could be interested in few specific areas.

Re: Review notification bot

Th configuration file is optional, is there something you want to try and change? On Mon, Jul 30, 2018 at 7:30 PM Hyukjin Kwon wrote: > I see. Thanks. I was wondering if I can see the configuration file since > that looks needed (https://github.com/holdenk/mention-bot#configuration) > but I

Re: Review notification bot

I see. Thanks. I was wondering if I can see the configuration file since that looks needed (https://github.com/holdenk/mention-bot#configuration) but I couldn't find (sorry if it's just something I simply missed). 2018년 7월 31일 (화) 오전 1:48, Holden Karau 님이 작성: > So the one that is running is the

Re: Review notification bot

So the one that is running is the the form in my own repo (set up for K8s deployment) - http://github.com/holdenk/mention-bot On Mon, Jul 30, 2018 at 3:15 AM Hyukjin Kwon wrote: > Holden, so, is it a fork in https://github.com/facebookarchive/mention-bot? > Would you mind if I ask where I can

Re: Review notification bot

Holden, so, is it a fork in https://github.com/facebookarchive/mention-bot? Would you mind if I ask where I can see the configurations for it? 2018년 7월 23일 (월) 오전 10:16, Holden Karau 님이 작성: > Yeah so the issue with codeowners is it will only assign to committers on > the repo (the Beam project

Re: Review notification bot

Yeah so the issue with codeowners is it will only assign to committers on the repo (the Beam project found this out the practical application way). I have a fork of mention bot running and it seems we can add it (need an infra ticket), but one of the things the Beam folks asked was to not ping

Re: Review notification bot

On this topic, I just stumbled on a GitHub feature called CODEOWNERS . It lets you specify owners of specific areas of the repository using the same syntax that .gitignore uses. Here is CPython's CODEOWNERS file

Re: Review notification bot

Hearing no objections (and in a shout out to @ Nicholas Chammas who initially suggested mention-bot back in 2016) I've set up a copy of mention bot and run it against my own repo (looks like https://github.com/holdenk/spark-testing-base/pull/253 ). If no one objects I’ll ask infra to turn this on

Re: Review notification bot

So there are a few bots along this line in OSS. If no one objects I’ll take a look and find one which matches our use case and try it out. On Wed, Jun 6, 2018 at 10:33 AM Sean Owen wrote: > Certainly I will frequently dig through 'git blame' to figure out who > might be the right reviewer.

Re: Review notification bot

Certainly I will frequently dig through 'git blame' to figure out who might be the right reviewer. Maybe that's automatable -- ping the person who last touched the most lines touched by the PR? There might be some false positives there. And I suppose the downside is being pinged forever for some

Review notification bot

Hi friends, Was chatting with some folks at the summit and I was wondering how people would feel about adding a review bot to ping folks. We already have the review dashboard but I was thinking we could ping folks who were the original authors of the code being changed whom might not be in the