Re: SPARK-942 patch review

2014-02-25 Thread Patrick Wendell
Hey Andrew, Ah, I just meant to say that in cases like this it's usually a mistake... and we try to (in general) be inclusive about merging patches :) Definitely appreciate you calling this one out... this is what people should do in cases like this. - Patrick On Tue, Feb 25, 2014 at 8:00 PM, A

Re: SPARK-942 patch review

2014-02-25 Thread Andrew Ash
I've always felt that the Spark team was extremely responsive to PRs and I've been very impressed over the past year with your output. As Matei said, probably the best thing to do here is to be more diligent about closing PRs that are old/abandoned so that every PR is active. Whenever I comment I

Re: SPARK-942 patch review

2014-02-25 Thread Patrick Wendell
Hey Andrew, Indeed, sometimes there are patches that sit around a while and in this case it can be because it's unclear to the reviewers whether they are features worth having - or just by accident. To put things in perspective, Spark merges about 80% of the proposed patches (if you look we are o