Re: SPIP: Catalog API for view metadata

2020-08-18 Thread John Zhuge
Thanks Burak and Walaa for the feedback! Here are my perspectives: We shouldn't be persisting things like the schema for a view This is not related to which option to choose because existing code persists schema as well. When resolving the view, the analyzer always parses the view sql text, it

Re: SPIP: Catalog API for view metadata

2020-08-18 Thread John Zhuge
Thanks Wenchen. Will do. On Tue, Aug 18, 2020 at 6:38 AM Wenchen Fan wrote: > > AFAIK view schema is only used by DESCRIBE. > > Correction: Spark adds a new Project at the top of the parsed plan from > view, based on the stored schema, to make sure the view schema doesn't > change. > > Can you

Re: SPIP: Catalog API for view metadata

2020-08-18 Thread Wenchen Fan
> AFAIK view schema is only used by DESCRIBE. Correction: Spark adds a new Project at the top of the parsed plan from view, based on the stored schema, to make sure the view schema doesn't change. Can you update your doc to incorporate the cache idea? Let's make sure we don't have perf issues if

Re: SPIP: Catalog API for view metadata

2020-08-18 Thread John Zhuge
> > AFAIK view schema is only used by DESCRIBE. > > Correction: Spark adds a new Project at the top of the parsed plan from > view, based on the stored schema, to make sure the view schema doesn't > change. > Thanks Wenchen! I thought I forgot something :) Yes it is the validation done in

Re: Running K8s integration tests for changes in core?

2020-08-18 Thread shane knapp ☠
yes, i think this is fine. the k8s prb runs concurrently to the regular prb and takes ~20m. On Tue, Aug 18, 2020 at 8:47 PM Holden Karau wrote: > Hi Dev Folks, > > I was wondering how people feel about enabling the K8s PRB automatically > for all core changes? Sometimes I forget that a change

Running K8s integration tests for changes in core?

2020-08-18 Thread Holden Karau
Hi Dev Folks, I was wondering how people feel about enabling the K8s PRB automatically for all core changes? Sometimes I forget that a change might impact one of the K8s integration tests since a bunch of them look at log messages. Would folks be OK with turning on the K8s integration PRB for all

Re: Running K8s integration tests for changes in core?

2020-08-18 Thread Prashant Sharma
+1, we should enable. On Wed, Aug 19, 2020 at 9:18 AM Holden Karau wrote: > Hi Dev Folks, > > I was wondering how people feel about enabling the K8s PRB automatically > for all core changes? Sometimes I forget that a change might impact one of > the K8s integration tests since a bunch of them