Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-17 Thread Dongjoon Hyun
Thank you all. The vote passed. I'll conclude this vote. Dongjooon. On 2024/04/16 04:58:39 Arun Dakua wrote: > +1 > > On Tue, Apr 16, 2024 at 12:50 AM Josh Rosen wrote: > > > +1 > > > > On Mon, Apr 15, 2024 at 11:26 AM Maciej wrote: > > > >> +1 > >> > >> Best regards, > >> Maciej

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Arun Dakua
+1 On Tue, Apr 16, 2024 at 12:50 AM Josh Rosen wrote: > +1 > > On Mon, Apr 15, 2024 at 11:26 AM Maciej wrote: > >> +1 >> >> Best regards, >> Maciej Szymkiewicz >> >> Web: https://zero323.net >> PGP: A30CEF0C31A501EC >> >> On 4/15/24 8:16 PM, Rui Wang wrote: >> >> +1, non-binding. >> >> Thanks

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Josh Rosen
+1 On Mon, Apr 15, 2024 at 11:26 AM Maciej wrote: > +1 > > Best regards, > Maciej Szymkiewicz > > Web: https://zero323.net > PGP: A30CEF0C31A501EC > > On 4/15/24 8:16 PM, Rui Wang wrote: > > +1, non-binding. > > Thanks Dongjoon to drive this! > > > -Rui > > On Mon, Apr 15, 2024 at 10:10 AM

Re: Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Takuya UESHIN
+1 On Mon, Apr 15, 2024 at 11:17 AM Rui Wang wrote: > +1, non-binding. > > Thanks Dongjoon to drive this! > > > -Rui > > On Mon, Apr 15, 2024 at 10:10 AM Xinrong Meng wrote: > >> +1 >> >> Thank you @Dongjoon Hyun ! >> >> On Mon, Apr 15, 2024 at 6:33 AM beliefer wrote: >> >>> +1 >>> >>> >>> 在

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Maciej
+1 Best regards, Maciej Szymkiewicz Web:https://zero323.net PGP: A30CEF0C31A501EC On 4/15/24 8:16 PM, Rui Wang wrote: +1, non-binding. Thanks Dongjoon to drive this! -Rui On Mon, Apr 15, 2024 at 10:10 AM Xinrong Meng wrote: +1 Thank you @Dongjoon Hyun

Re: Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Rui Wang
+1, non-binding. Thanks Dongjoon to drive this! -Rui On Mon, Apr 15, 2024 at 10:10 AM Xinrong Meng wrote: > +1 > > Thank you @Dongjoon Hyun ! > > On Mon, Apr 15, 2024 at 6:33 AM beliefer wrote: > >> +1 >> >> >> 在 2024-04-15 15:54:07,"Peter Toth" 写道: >> >> +1 >> >> Wenchen Fan ezt írta

Re: Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Xinrong Meng
+1 Thank you @Dongjoon Hyun ! On Mon, Apr 15, 2024 at 6:33 AM beliefer wrote: > +1 > > > 在 2024-04-15 15:54:07,"Peter Toth" 写道: > > +1 > > Wenchen Fan ezt írta (időpont: 2024. ápr. 15., H, > 9:08): > >> +1 >> >> On Sun, Apr 14, 2024 at 6:28 AM Dongjoon Hyun >> wrote: >> >>> I'll start from

Re:Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread beliefer
+1 在 2024-04-15 15:54:07,"Peter Toth" 写道: +1 Wenchen Fan ezt írta (időpont: 2024. ápr. 15., H, 9:08): +1 On Sun, Apr 14, 2024 at 6:28 AM Dongjoon Hyun wrote: I'll start from my +1. Dongjoon. On 2024/04/13 22:22:05 Dongjoon Hyun wrote: > Please vote on SPARK-4 to use ANSI SQL

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Peter Toth
+1 Wenchen Fan ezt írta (időpont: 2024. ápr. 15., H, 9:08): > +1 > > On Sun, Apr 14, 2024 at 6:28 AM Dongjoon Hyun wrote: > >> I'll start from my +1. >> >> Dongjoon. >> >> On 2024/04/13 22:22:05 Dongjoon Hyun wrote: >> > Please vote on SPARK-4 to use ANSI SQL mode by default. >> > The

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread Cheng Pan
+1, non-binding Thanks, Cheng Pan > On Apr 15, 2024, at 14:14, John Zhuge wrote: > > +1 (non-binding) > > On Sun, Apr 14, 2024 at 7:18 PM Jungtaek Lim > wrote: > +1 (non-binding), thanks Dongjoon. > > On Sun, Apr 14, 2024 at 7:22 AM Dongjoon Hyun wrote: > Please vote on SPARK-4 to

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-15 Thread John Zhuge
+1 (non-binding) On Sun, Apr 14, 2024 at 7:18 PM Jungtaek Lim wrote: > +1 (non-binding), thanks Dongjoon. > > On Sun, Apr 14, 2024 at 7:22 AM Dongjoon Hyun > wrote: > >> Please vote on SPARK-4 to use ANSI SQL mode by default. >> The technical scope is defined in the following PR which is

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-14 Thread Jungtaek Lim
+1 (non-binding), thanks Dongjoon. On Sun, Apr 14, 2024 at 7:22 AM Dongjoon Hyun wrote: > Please vote on SPARK-4 to use ANSI SQL mode by default. > The technical scope is defined in the following PR which is > one line of code change and one line of migration guide. > > - DISCUSSION: >

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-14 Thread Wenchen Fan
+1 On Sun, Apr 14, 2024 at 6:28 AM Dongjoon Hyun wrote: > I'll start from my +1. > > Dongjoon. > > On 2024/04/13 22:22:05 Dongjoon Hyun wrote: > > Please vote on SPARK-4 to use ANSI SQL mode by default. > > The technical scope is defined in the following PR which is > > one line of code

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-14 Thread yangjie01
+1 for me Jie Yang 发件人: Mich Talebzadeh 日期: 2024年4月14日 星期日 15:41 收件人: Dongjoon Hyun , Spark dev list 主题: Re: [VOTE] SPARK-4: Use ANSI SQL mode by default + 1 for me It makes it more compatible with the other ANSI SQL compliant products. Mich Talebzadeh, Technologist | Solutions

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-14 Thread Christiano Anderson
+1 On 14/04/2024 00:22, Dongjoon Hyun wrote: Please vote on SPARK-4 to use ANSI SQL mode by default. The technical scope is defined in the following PR which is one line of code change and one line of migration guide. - DISCUSSION:

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-14 Thread Mich Talebzadeh
+ 1 for me It makes it more compatible with the other ANSI SQL compliant products. Mich Talebzadeh, Technologist | Solutions Architect | Data Engineer | Generative AI London United Kingdom view my Linkedin profile

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Xiao Li
+1 On Sat, Apr 13, 2024 at 17:21 huaxin gao wrote: > +1 > > On Sat, Apr 13, 2024 at 4:36 PM L. C. Hsieh wrote: > >> +1 >> >> On Sat, Apr 13, 2024 at 4:12 PM Hyukjin Kwon >> wrote: >> > >> > +1 >> > >> > On Sun, Apr 14, 2024 at 7:46 AM Chao Sun wrote: >> >> >> >> +1. >> >> >> >> This feature

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Denny Lee
+1 (non-binding) On Sat, Apr 13, 2024 at 7:49 PM huaxin gao wrote: > +1 > > On Sat, Apr 13, 2024 at 4:36 PM L. C. Hsieh wrote: > >> +1 >> >> On Sat, Apr 13, 2024 at 4:12 PM Hyukjin Kwon >> wrote: >> > >> > +1 >> > >> > On Sun, Apr 14, 2024 at 7:46 AM Chao Sun wrote: >> >> >> >> +1. >> >> >>

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread huaxin gao
+1 On Sat, Apr 13, 2024 at 4:36 PM L. C. Hsieh wrote: > +1 > > On Sat, Apr 13, 2024 at 4:12 PM Hyukjin Kwon wrote: > > > > +1 > > > > On Sun, Apr 14, 2024 at 7:46 AM Chao Sun wrote: > >> > >> +1. > >> > >> This feature is very helpful for guarding against correctness issues, > such as null

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Holden Karau
+1 -- even if it's not perfect now is the time to change default values On Sat, Apr 13, 2024 at 4:11 PM Hyukjin Kwon wrote: > +1 > > On Sun, Apr 14, 2024 at 7:46 AM Chao Sun wrote: > >> +1. >> >> This feature is very helpful for guarding against correctness issues, >> such as null results due

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread L. C. Hsieh
+1 On Sat, Apr 13, 2024 at 4:12 PM Hyukjin Kwon wrote: > > +1 > > On Sun, Apr 14, 2024 at 7:46 AM Chao Sun wrote: >> >> +1. >> >> This feature is very helpful for guarding against correctness issues, such >> as null results due to invalid input or math overflows. It’s been there for >> a

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Hyukjin Kwon
+1 On Sun, Apr 14, 2024 at 7:46 AM Chao Sun wrote: > +1. > > This feature is very helpful for guarding against correctness issues, such > as null results due to invalid input or math overflows. It’s been there for > a while now and it’s a good time to enable it by default as Spark enters > the

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Chao Sun
+1. This feature is very helpful for guarding against correctness issues, such as null results due to invalid input or math overflows. It’s been there for a while now and it’s a good time to enable it by default as Spark enters the next major release. On Sat, Apr 13, 2024 at 3:27 PM Dongjoon

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Gengliang Wang
+1 On Sat, Apr 13, 2024 at 3:26 PM Dongjoon Hyun wrote: > I'll start from my +1. > > Dongjoon. > > On 2024/04/13 22:22:05 Dongjoon Hyun wrote: > > Please vote on SPARK-4 to use ANSI SQL mode by default. > > The technical scope is defined in the following PR which is > > one line of code

Re: [VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Dongjoon Hyun
I'll start from my +1. Dongjoon. On 2024/04/13 22:22:05 Dongjoon Hyun wrote: > Please vote on SPARK-4 to use ANSI SQL mode by default. > The technical scope is defined in the following PR which is > one line of code change and one line of migration guide. > > - DISCUSSION: >

[VOTE] SPARK-44444: Use ANSI SQL mode by default

2024-04-13 Thread Dongjoon Hyun
Please vote on SPARK-4 to use ANSI SQL mode by default. The technical scope is defined in the following PR which is one line of code change and one line of migration guide. - DISCUSSION: https://lists.apache.org/thread/ztlwoz1v1sn81ssks12tb19x37zozxlz - JIRA: