Re: [Catalyst] RFC: Using PartialFunction literals instead of objects

2015-05-20 Thread Edoardo Vacchi
Thanks for the prompt feedback; I have further expanded on your suggestions on this JIRA https://issues.apache.org/jira/browse/SPARK-7754 On Tue, May 19, 2015 at 8:35 PM, Michael Armbrust wrote: > Overall this seems like a reasonable proposal to me. Here are a few > thoughts: > > - There is som

Re: [Catalyst] RFC: Using PartialFunction literals instead of objects

2015-05-19 Thread Michael Armbrust
Overall this seems like a reasonable proposal to me. Here are a few thoughts: - There is some debugging utility to the ruleName, so we would probably want to at least make that an argument to the rule function. - We also have had rules that operate on SparkPlan, though since there is only one A

[Catalyst] RFC: Using PartialFunction literals instead of objects

2015-05-19 Thread Edoardo Vacchi
Hi everybody, At the moment, Catalyst rules are defined using two different types of rules: `Rule[LogicalPlan]` and `Strategy` (which in turn maps to `GenericStrategy[SparkPlan]`). I propose to introduce utility methods to a) reduce the boilerplate to define rewrite rules b) turning them bac