Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-16 Thread Wenchen Fan
This vote passes with 3 binding +1 votes, 5 non-binding votes, and no -1 votes. Thanks all! +1 votes (binding): Wenchen Fan Reynold Xin Cheng Liang +1 votes (non-binding): Xiao Li Weichen Xu Vaquar khan Liwei Lin Dongjoon Hyun On Tue, Oct 17, 2017 at 12:30 AM, Dongjoon Hyun

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-16 Thread Cheng Lian
+1 On 10/12/17 20:10, Liwei Lin wrote: +1 ! Cheers, Liwei On Thu, Oct 12, 2017 at 7:11 PM, vaquar khan > wrote: +1 Regards, Vaquar khan On Oct 11, 2017 10:14 PM, "Weichen Xu"

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-12 Thread Liwei Lin
+1 ! Cheers, Liwei On Thu, Oct 12, 2017 at 7:11 PM, vaquar khan wrote: > +1 > > Regards, > Vaquar khan > > On Oct 11, 2017 10:14 PM, "Weichen Xu" wrote: > > +1 > > On Thu, Oct 12, 2017 at 10:36 AM, Xiao Li wrote: > >> +1

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-12 Thread vaquar khan
+1 Regards, Vaquar khan On Oct 11, 2017 10:14 PM, "Weichen Xu" wrote: +1 On Thu, Oct 12, 2017 at 10:36 AM, Xiao Li wrote: > +1 > > Xiao > > On Mon, 9 Oct 2017 at 7:31 PM Reynold Xin wrote: > >> +1 >> >> One thing with

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-11 Thread Weichen Xu
+1 On Thu, Oct 12, 2017 at 10:36 AM, Xiao Li wrote: > +1 > > Xiao > > On Mon, 9 Oct 2017 at 7:31 PM Reynold Xin wrote: > >> +1 >> >> One thing with MetadataSupport - It's a bad idea to call it that unless >> adding new functions in that trait wouldn't

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-11 Thread Xiao Li
+1 Xiao On Mon, 9 Oct 2017 at 7:31 PM Reynold Xin wrote: > +1 > > One thing with MetadataSupport - It's a bad idea to call it that unless > adding new functions in that trait wouldn't break source/binary > compatibility in the future. > > > On Mon, Oct 9, 2017 at 6:07 PM,

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-09 Thread Reynold Xin
+1 One thing with MetadataSupport - It's a bad idea to call it that unless adding new functions in that trait wouldn't break source/binary compatibility in the future. On Mon, Oct 9, 2017 at 6:07 PM, Wenchen Fan wrote: > I'm adding my own +1 (binding). > > On Tue, Oct 10,

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-09 Thread Wenchen Fan
I'm adding my own +1 (binding). On Tue, Oct 10, 2017 at 9:07 AM, Wenchen Fan wrote: > I'm going to update the proposal: for the last point, although the > user-facing API (`df.write.format(...).option(...).mode(...).save()`) > mixes data and metadata operations, we are

Re: [VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-09 Thread Wenchen Fan
I'm going to update the proposal: for the last point, although the user-facing API (`df.write.format(...).option(...).mode(...).save()`) mixes data and metadata operations, we are still able to separate them in the data source write API. We can have a mix-in trait `MetadataSupport` which has a

[VOTE][SPIP] SPARK-22026 data source v2 write path

2017-10-02 Thread Wenchen Fan
Hi all, After we merge the infrastructure of data source v2 read path, and have some discussion for the write path, now I'm sending this email to call a vote for Data Source v2 write path. The full document of the Data Source API V2 is: