FYI: scalastyle just merged in a patch to add support for external rules
https://github.com/scalastyle/scalastyle/issues/25#ref-commit-9a576c3.
I forget why I was following the linked issue, but I assume it's related to
this discussion.
Nick
On Thu Oct 09 2014 at 2:56:30 AM Reynold Xin
I've created SPARK-3849: Automate remaining Scala style rules
https://issues.apache.org/jira/browse/SPARK-3849.
Please create sub-tasks on this issue for rules that we have not automated
and let's work through them as possible.
I went ahead and created the first sub-task, SPARK-3850: Scala
For starters, do we have a list of all the Scala style rules that are
currently not enforced automatically but are likely well-suited for
automation?
Let's put such a list together in a JIRA issue and work through
implementing them.
Nick
On Thu, Oct 2, 2014 at 12:06 AM, Cheng Lian
Please take a look at WhitespaceEndOfLineChecker under:
http://www.scalastyle.org/rules-0.1.0.html
Cheers
On Wed, Oct 1, 2014 at 2:01 PM, Nicholas Chammas nicholas.cham...@gmail.com
wrote:
As discussed here https://github.com/apache/spark/pull/2619, it would be
good to extend our Scala style
Hey Nick,
We can always take built-in rules. Back when we added this Prashant
Sharma actually did some great work that lets us write our own style
rules in cases where rules don't exist.
You can see some existing rules here:
Ah, since there appears to be a built-in rule for end-of-line whitespace,
Michael and Cheng, y'all should be able to add this in pretty easily.
Nick
On Wed, Oct 1, 2014 at 6:37 PM, Patrick Wendell pwend...@gmail.com wrote:
Hey Nick,
We can always take built-in rules. Back when we added this
The hard part here is updating the existing code base... which is going to
create merge conflicts with like all of the open PRs...
On Wed, Oct 1, 2014 at 6:13 PM, Nicholas Chammas nicholas.cham...@gmail.com
wrote:
Ah, since there appears to be a built-in rule for end-of-line whitespace,
Yeah, I remember that hell when I added PEP 8 to the build checks and fixed
all the outstanding Python style issues. I had to keep rebasing and
resolving merge conflicts until the PR was merged.
It's a rough process, but thankfully it's also a one-time process. I might
be able to help with that
Does anyone know if Scala has something equivalent to autopep8
https://pypi.python.org/pypi/autopep8? It would help patch up the
existing code base a lot quicker as we add in new style rules.
On Wed, Oct 1, 2014 at 9:24 PM, Nicholas Chammas nicholas.cham...@gmail.com
wrote:
Yeah, I remember
There is scalariform but it can be disruptive. Last time I ran it on Spark
it didn't compile due to some xml interpolation problem.
On Wednesday, October 1, 2014, Nicholas Chammas nicholas.cham...@gmail.com
wrote:
Does anyone know if Scala has something equivalent to autopep8
Since we can easily catch the list of all changed files in a PR, I think
we can start with adding the no trailing space check for newly changed
files only?
On 10/2/14 9:24 AM, Nicholas Chammas wrote:
Yeah, I remember that hell when I added PEP 8 to the build checks and fixed
all the
11 matches
Mail list logo
