.
Do you think I should write to him (or whoever I¹m working with for the
review) personally instead of spamming the list? I really don¹t want to
create more noise for you guys but it¹s hard to tell when a patch has been
forgotten.
Punya
On 2/22/14, 7:05 PM, "Patrick Wendell" wrote:
Hi all,
Can someone review and/or merge PR #605
<https://github.com/apache/incubator-spark/pull/605> (convert or move Java
code)? It¹s been sitting for four days.
Thanks!
Punya
smime.p7s
Description: S/MIME cryptographic signature
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35656179
@aarondav is this ready to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9849897
This is great -- when I first read the weird ClassTag pattern I was puzzled
about its apparent dishonesty. Rebased and changed, here and elsewhere.
---
If your
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9849872
Done (here and elsewhere).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35454254
Unfortunately, a val in an object translates into a zero-argument static
method rather than a static final field. There was a plan to add a @static
annotation in
Apologies, I see that Aaron¹s already on it. Please disregard the noise.
Punya
From: Punya Biswal
Reply-To:
Date: Tuesday, February 18, 2014 at 7:00 PM
To: "dev@spark.incubator.apache.org"
Subject: Request to review PR#605: migrate Java code to Scala or
src/main/java
Hi a
Hi all,
Could someone review my pull request
<https://github.com/apache/incubator-spark/pull/605> ? I implemented Aaron¹s
initial suggestion and all tests appear to pass.
Punya
smime.p7s
Description: S/MIME cryptographic signature
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35322379
@aarondav can I get a review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35316168
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35301961
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35230127
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35228237
I'll give it a shot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
GitHub user punya opened a pull request:
https://github.com/apache/incubator-spark/pull/605
Move all Java code to src/main/java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-spark move-java-sources
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35226354
Thanks @aarondav! I wondered about the dishonest `ClassTag`s too but
convinced myself that in this case it was totally harmless because
`subtractByKey` ignores
Github user punya closed the pull request at:
https://github.com/apache/incubator-spark/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this
Dear Spark devs,
Can someone review my pull request
(https://github.com/apache/incubator-spark/pull/600), which adds
subtractByKey to JavaPairRDD? Thanks!
Punya
smime.p7s
Description: S/MIME cryptographic signature
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35113788
Jenkins, test this please.
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35097483
@pwendell, the build hasn't retriggered even though I updated my patch.
Could you please ask Jenkins to test this pull request.
GitHub user punya opened a pull request:
https://github.com/apache/incubator-spark/pull/600
Add subtractByKey to the JavaPairRDD wrapper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-spark subtractByKey-java
20 matches
Mail list logo
