Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35920859
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/629#issuecomment-35776515
Yup, good idea. I also cherry picked it into branch-0.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/629#issuecomment-35771699
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user rxin commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/629#discussion_r9956743
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -212,7 +212,7 @@ class ALS private (var numBlocks: Int, var rank
Github user rxin commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/629#discussion_r9956734
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -212,7 +212,7 @@ class ALS private (var numBlocks: Int, var rank
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/500#issuecomment-35596136
Merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35592012
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/610#issuecomment-35469927
Yes, I agree for primitive types as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/610#issuecomment-35469499
This discussion should probably have happened on the mailing list, but here
you go.
In general I think we should favor explicit type declaration in public
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#discussion_r9853229
Need to wrap the line so it fits within 100 chars.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35461371
Do you mind creating a JIRA ticket and update the pull request title to
include that?
---
If your project is set up for it, you can reply to this email and have
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/617#issuecomment-35459852
Ok I merged this. Thanks guys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/617#issuecomment-35459609
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/575#issuecomment-35445845
@fommil maybe that changed in 2.10.x entirely given the addition of value
classes, and maybe Breeze is very careful in its implicit usage, but often
implicits in
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/613#issuecomment-35431514
I made one comment on the ambiguity of Double. Other than that, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/613#discussion_r9840393
We should probably rename this JDouble or just use java.lang.Double in the
codebase.
---
If your project is set up for it, you can reply to this email and have
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/604#issuecomment-35349097
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/607#issuecomment-35327669
Thanks for submitting this. One discussion we need to have before merging
this is on the long term support for the async scala APIs. When I added those,
they were
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/572#discussion_r9805702
Basically you want to make sure it is obvious that this returns a tuple
(which can also be done through explicit type declaration but probably simpler
this way
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/572#discussion_r9802309
```scala
(1 to numFolds).map { fold =>
val sampler = new BernoulliSampler[T]((fold-1)/foldsF,fold/foldsF,
complement = false)
val train =
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/402#issuecomment-35061130
Great. @ScrapCodes can you mark the scala *With's as deprecated in 1.0.0,
and remove the java apis from this pr?
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/123#issuecomment-35059482
ping @kayousterhout
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/402#issuecomment-35059461
I agree with you. I actually think we should consider deprecating them for
Scala as well. The same sentiment is also echoed by @markhamstra who initially
wrote
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/593#issuecomment-35029540
Closing since it's been merged.
Github user rxin closed the pull request at:
https://github.com/apache/incubator-spark/pull/593
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/593#issuecomment-34954956
Ok I merged this using the new script!
Github user rxin closed the pull request at:
https://github.com/apache/incubator-spark/pull/592
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/590#issuecomment-34953037
Closing this one since it has been merged.
Github user rxin closed the pull request at:
https://github.com/apache/incubator-spark/pull/590
GitHub user rxin opened a pull request:
https://github.com/apache/incubator-spark/pull/593
SPARK-1088: Create a script for running tests so we can have version
specific testing on Jenkins (branch-0.9)
This is for branch-0.9.
#592 is for master branch (1.0).
You can merge
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/592#issuecomment-34952038
Yea. It just ran a script similar to this, except it is not a "script",
just a sequence of commands defined in jenkins.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/592#issuecomment-34949375
As suggested in #590.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/592#issuecomment-34948410
I will submit another one for branch-0.9 if this looks good.
GitHub user rxin opened a pull request:
https://github.com/apache/incubator-spark/pull/592
SPARK-1088: Create a script for running tests so we can have version
specific testing on Jenkins.
@pwendell
You can merge this pull request into a Git repository by running:
$ git pull
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/590#issuecomment-34947355
That's a good idea. I will submit a PR.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/591#issuecomment-34935532
Ok I'm merging this one. Thanks.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/584#issuecomment-34923271
We can test this once #590 is in.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/590#issuecomment-34923019
@aarondav @marmbrus
i'm no sbt expert
GitHub user rxin opened a pull request:
https://github.com/apache/incubator-spark/pull/590
SPARK-1085: Fix Jenkins pull request builder for branch-0.9 (scalastyle
command not found)
Added a dummy scalastyle task to sbt.
https://spark-project.atlassian.net/browse/SPARK-1085
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/587#issuecomment-34916300
Thanks for submitting this. Just curious, what is the advantage of this
over rdd.cartesian(rdd), i.e. just use cartesian to join itself?
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34901501
Thanks. Merged.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-34850552
It's probably good to have the result sent to the dev list at some point.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-34849894
Do you have an example of the report?
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/574#issuecomment-34849557
@pwendell comment? Would be great to have this merged soon.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/379#issuecomment-34849506
@ash211 mind closing this for now? We should revisit this when we find a
solution.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/578#issuecomment-34848995
Thanks. Merging this.
We might need to add Java / Python APIs too ... but that can be done in a
later PR.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/578#issuecomment-34847266
Jenkins, retest this please.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/578#issuecomment-34846154
lgtm. will merge once jenkins is happy
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/584#issuecomment-34844952
BTW Jenkins desire assertiveness. By asking him whether you could do this,
he wouldn't do it ...
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/584#issuecomment-34844932
It's because branch-0.9 doesn't have the scalastyle stuff ...
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/584#issuecomment-34844882
Jenkins, retest this please.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/578#issuecomment-34844284
BTW - the new dev rules require us to create a JIRA for this, and update
the PR description to include a link to the JIRA.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/571#issuecomment-34818238
Thanks. I've merged this.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/577#issuecomment-34817976
Thanks. I've merged this.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801246
Jenkins, add to whitelist.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/579#issuecomment-34729446
Thanks. Merged.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/571#issuecomment-34607475
Our Jenkins style checker actually worked!!!
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/572#issuecomment-34606676
Jenkins, add to whitelist.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/567#issuecomment-34603519
Thanks! I'm merging this now.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/567#issuecomment-34603004
Jenkins, retest this please.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/500#issuecomment-34601206
Thanks, @mengxr and @MLnick for reviewing this.
@srowen this is no longer mergeable due to the style update pr. Do you mind
updating the PR so it can be
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/566#issuecomment-34591185
Thanks. I've merged this.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/567#issuecomment-34589963
Thanks, @ScrapCodes, for doing this! I just went through all your changes.
I made some comments to improve the readability of some line wraps. Often you
want to
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/566#issuecomment-34588467
Thanks for rebasing this. There's a couple small conflicts, likely from the
style cleanup pull request. Do you mind updating this so it can be merged
cleanly?
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/551#issuecomment-34588354
LGTM. Merging this now. Thanks!
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/569#issuecomment-34588246
Ok I merged this PR using the script in this PR. Let's see ...
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/551#issuecomment-34567984
Thanks. I left some comments to improve readability of the code.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/560#issuecomment-34567839
Oops I didn't realize the WIP in title. Feel free to revert if necessary.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/556#issuecomment-34567822
Thanks. I merged this in master.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/562#issuecomment-34567786
Thanks. Merged this in master & branch-0.9.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/560#issuecomment-34567772
Ok merged in master & branch-0.9.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/565#issuecomment-34567423
Ok I merged it. Thanks!
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/563#issuecomment-34565306
Maybe you can create a patch, and apply that patch directly on master?
The changes look pretty easy to apply to me, so it shouldn't be too hard.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/563#issuecomment-34559900
(And then submit a new PR and close this one)
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/563#issuecomment-34559894
To play it safe, you can always create a new branch and do the rebase there
so it doesn't change your current branch.
75 matches
Mail list logo
