Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35908324
@ScrapCodes I'm looking at your suggestion, the difficulty to move to
createInterpreter() is that you cannot not pass the parameter "settings" to
there, do you
Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35880521
@ScrapCodes thank you very much
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, pleas
Github user ScrapCodes commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35862636
Also from this I just went ahead and tried fixing this problem in scala and
it worked.
https://github.com/ScrapCodes/scala/tree/si-6502-fix
---
If your p
Github user ScrapCodes commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35859704
Nice catch ! and thanks for taking the time to dig this. I am okay with
this way of doing it, however if you and others prefer we can move this code to
create
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/614#discussion_r9972921
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -876,7 +876,14 @@ class SparkILoop(in0: Option[BufferedReader],
protecte
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/614#discussion_r9972883
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -876,7 +876,14 @@ class SparkILoop(in0: Option[BufferedReader],
protecte
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/614#discussion_r9972843
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -876,7 +876,14 @@ class SparkILoop(in0: Option[BufferedReader],
protected
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35811284
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35811286
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12812/
---
If you
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/614#discussion_r9972360
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -876,7 +876,14 @@ class SparkILoop(in0: Option[BufferedReader],
protecte
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35809789
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35809788
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/614#discussion_r9972298
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -876,7 +876,14 @@ class SparkILoop(in0: Option[BufferedReader],
protected
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35809765
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/614#discussion_r9972286
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -876,7 +876,14 @@ class SparkILoop(in0: Option[BufferedReader],
protected
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35809685
// @scrapcodes - mind reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so,
Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/614#issuecomment-35806096
any discussion on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-po
17 matches
Mail list logo
