Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35226744
No need for your renaming PR @punya -- I've already taken care of it in
#604 :) Thanks!
---
If your project is set up for it, you can reply to this email and h
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35226354
Thanks @aarondav! I wondered about the dishonest `ClassTag`s too but
convinced myself that in this case it was totally harmless because
`subtractByKey` ignores the
Github user punya closed the pull request at:
https://github.com/apache/incubator-spark/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35225376
This PR doesn't need to block on this discussion, since it doesn't actually
rely on the fake ClassTag, so I've merged it into master.
I've created
[JIR
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35208921
To answer my own question, the reason we do this is probably because we
have no choice when integrating with Java. Additionally, use of ClassTag as in
our API r
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35207151
CC @pwendell and @JoshRosen
This looks good to me in that it should work in the style elsewhere in this
file, but I have a question for someone more kn
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#discussion_r9778178
"cm" is back from when these were ClassManifests. Everywhere else it's
still called that, though, so maybe this is a minor cleanup for another PR.
If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35116858
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12719/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35116857
Merged build finished.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35114288
Merged build started.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35114287
Merged build triggered.
Github user JoshRosen commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35114189
Jenkins, this is ok to test.
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35113788
Jenkins, test this please.
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35097483
@pwendell, the build hasn't retriggered even though I updated my patch.
Could you please ask Jenkins to test this pull request.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35058869
Merged build finished.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35058870
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12713/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35058812
Merged build triggered.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35058813
Merged build started.
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35058750
Jenkins, test this please.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/600#issuecomment-35051869
Can one of the admins verify this patch?
GitHub user punya opened a pull request:
https://github.com/apache/incubator-spark/pull/600
Add subtractByKey to the JavaPairRDD wrapper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-spark subtractByKey-java
A
21 matches
Mail list logo
