[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35854653 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12824/ --- If you

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35854651 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35852739 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35852737 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please t

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9805702 Basically you want to make sure it is obvious that this returns a tuple (which can also be done through explicit type declaration but probably simpler this way) ---

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9802309 ```scala (1 to numFolds).map { fold => val sampler = new BernoulliSampler[T]((fold-1)/foldsF,fold/foldsF, complement = false) val train = new Partition

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-17 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9801137 (1 to folds) is preferred, your style is fine though we use 2 space wrapped indents instead of 4. Would this be possible, though? ``` (1 to folds).map { fo

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-17 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9800999 I'm not sure which style to use. @rxin ? I prefer the following: ~~~ map { fold => ( // "((" seems to be unnecessar

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35225143 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12734/ --- If you

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35225140 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35224269 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please t

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-35224270 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9781015 Removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9780813 SharedSparkContext isn't available inside of mllutils tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9780345 Changed in both places. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post y

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9780341 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If yo

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9780337 oops, fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/incubator-spark/pull/572#discussion_r9780330 Done :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34915737 Merged build finished.

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34915739 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12695/

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34912554 Merged build triggered.

[GitHub] incubator-spark pull request: MLI-2: Start adding k-fold cross val...

2014-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34912556 Merged build started.