Github user asfgit closed the pull request at:
https://github.com/apache/incubator-spark/pull/605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this featur
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35821340
Thanks, LGTM! Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, plea
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35656179
@aarondav is this ready to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35461451
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35461454
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12771/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35459066
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35458603
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35455285
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12769/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35455283
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35455182
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35455183
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9850119
The exact same confusion led me to centralize and document this :)
Just as a stylistic thing, I think we can put these on one line (that's the
ideal for s
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35454755
Ah, got it. I actually didn't realize that StorageLevel.scala is the Scala
version, and StorageLevels is the Java version (clear naming scheme we got
going ther
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9849897
This is great -- when I first read the weird ClassTag pattern I was puzzled
about its apparent dishonesty. Rebased and changed, here and elsewhere.
---
If your proj
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9849872
Done (here and elsewhere).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35454254
Unfortunately, a val in an object translates into a zero-argument static
method rather than a static final field. There was a plan to add a @static
annotation in S
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35432171
Any reason not to convert StorageLevels as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9841053
I'm like 85% sure we can use scala.Serializable (which extends
java.io.Serializable) and should not require an import.
---
If your project is set up for it, you
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9841070
same here
`def returnType(): ClassTag[R] = JavaSparkContext.fakeClassTag`
---
If your project is set up for it, you can reply to this email and have your
repl
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#discussion_r9840846
Hm, let's use JavaSparkContext's fakeClassTag method, so we link to the
documentation on why we're doing this. You may have to rebase to get this, it
was a recent
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35322379
@aarondav can I get a review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35318592
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35318595
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12752/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35316247
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35316245
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35316168
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-pos
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35311100
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12750/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35311099
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35310306
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35310307
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35308071
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12749/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35308070
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35307804
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35307803
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35306966
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35306920
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35306921
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35306967
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12746/
---
Github user shivaram commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35306867
I am not sure, but I think the add to whitelist works from the next time a
commit is made.
---
If your project is set up for it, you can reply to this email an
Github user shivaram commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35306727
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-p
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35305983
Jenkins whitelist is separate from Jenkins admins, the latter of which is
explicitly managed by the people who run the AMPLab Jenkins, alas.
Jenkins, ad
Github user ash211 commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35305383
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-po
Github user ash211 commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35305400
(not sure if that's going to work)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, pleas
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35301961
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-pos
Github user punya commented on the pull request:
https://github.com/apache/incubator-spark/pull/605#issuecomment-35230127
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-pos
45 matches
Mail list logo