[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-17 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35328014 @nicklan @mateiz as an alternative, it might be simplest to just download a Tachyon package (e.g. don't use maven to deal with this). And have a nice graceful d

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-17 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35316947 @mateiz @nicklan - I think it's fine to ask Tachyon to publish this stuff in their jars. Having Tachyon code inside of the Spark codebase is not good for a bunc

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-16 Thread nicklan
Github user nicklan commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35229452 @mateiz I agree it would be good to have the tachyon scripts inside the jar, but afaik there isn't currently a JAR available with them anywhere, so I just copied

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-16 Thread nicklan
Github user nicklan commented on the pull request: https://github.com/apache/incubator-spark/pull/603#discussion_r9782432 Not sure on this one, but spark shouldn't end up having this on the classpath anyway right, since it's buried in the sbin/tachyon folder --- If your project is se

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-16 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35223558 @aarondav we don't, Tachyon actually compiles them at runtime it seems, but you can compile them when you publish the Tachyon JAR to avoid that. --- If your proj

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-16 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35221556 Sorry if this is a stupid question, but why do we need Tachyon JSPs? Are we going to host Tachyon pages from our own UI? --- If your project is set up for it,

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-16 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/incubator-spark/pull/603#discussion_r9780128 I don't know much about log4j, but could this accidentally override Spark's own logging properties if it is the first log4j.properties file found on the classpath

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-15 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35172028 On a related note, it may be worth to fetch the Tachyon scripts from Maven as a JAR as well, and unzip them only during the make-distribution.sh process. That way

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-15 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/incubator-spark/pull/603#issuecomment-35171986 Hey Nick, regarding the Tachyon JSPs and web resources, couldn't those be included in a Maven artifact published by Tachyon? JSPs should be compilable once and th

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-15 Thread alig
Github user alig commented on the pull request: https://github.com/apache/incubator-spark/pull/603#discussion_r9774589 Should probably also add --with-tachyon as part of the optional parameters around line 30 in this file. If your project is set up for it, you can reply to this email

[GitHub] incubator-spark pull request: Tachyon scripts

2014-02-15 Thread nicklan
Github user nicklan commented on the pull request: https://github.com/apache/incubator-spark/pull/603#discussion_r9773703 Yep, that's why the grep is there, so it will only print if it actually kills something. The tachyon stop-master and stop-worker scripts look specifically for the