Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35474694
Build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35474696
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12775/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/610#issuecomment-35474701
Build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/610#issuecomment-35474702
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12776/
---
If you
You are right.
A degenerate case would be :
def createFoo = new FooImpl()
vs
def createFoo: Foo = new FooImpl()
Former will cause api instability. Reynold, maybe this is already
avoided - and I understood it wrong ?
Thanks,
Mridul
On Wed, Feb 19, 2014 at 12:44 PM, Christopher Nguyen wrote:
Yes, the case you brought up is not a matter of readability or style. If it
returns a different type, it should be declared (otherwise it is just
wrong).
On Wed, Feb 19, 2014 at 12:17 AM, Mridul Muralidharan wrote:
> You are right.
> A degenerate case would be :
>
> def createFoo = new FooImpl()
Github user CrazyJvm commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35476826
There seems no problem to use yahoo link. Or you are worried about the link
might be invalid again?
@mengxr
---
If your project is set up for it, you can
Github user NirmalReddy commented on the pull request:
https://github.com/apache/incubator-spark/pull/610#issuecomment-35480180
@aarondav With this last commit i suppose i have completed the
issue.(Spark-1095)
---
If your project is set up for it, you can reply to this email and have
Hi,
I am trying to use Apache spark on a Standalone cluster.
After downloading the Spark I tried to build the package. However I am getting
following error for the normal build using default Hadoop:
gino@gino008:~/Downloads/spark-0.9.0-incubating$ sbt assembly
Loading /usr/share/sbt/bin/sbt-laun
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35491848
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35491849
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/539#discussion_r9862681
--- Diff: project/build.properties ---
@@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitatio
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9863061
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,115 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user ScrapCodes commented on the pull request:
https://github.com/apache/incubator-spark/pull/402#issuecomment-35494734
@pwendell are you okay with the changes ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To d
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35496676
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35496679
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12777/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35496756
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35496755
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35496741
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35496740
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35496818
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35496819
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12778/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35496946
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35496947
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35497321
@mengxr DOI link may not be accessible to non-paid users, I think yahoo
research is relatively stable enough
---
If your project is set up for it, you can rep
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35501417
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35501419
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12779/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35501415
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12780/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35501414
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/332#discussion_r9868173
--- Diff: core/src/main/java/org/apache/spark/SparkSaslServer.java ---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user tgravescs commented on the pull request:
https://github.com/apache/incubator-spark/pull/555#issuecomment-35513822
@sryza can this be closed then? I think the important note you added to
the running on yarn about the cores will suffice alone with my security PR.
---
If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35514616
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35514615
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/618#discussion_r9870730
--- Diff: docs/index.md ---
@@ -19,7 +19,7 @@ Spark uses [Simple Build Tool](http://www.scala-sbt.org),
which is bundled with
sbt/sbt
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/618#issuecomment-35516252
LGTM pending a small fix -- @aarondav want to take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
+1 overall.
Christopher - I agree that once the number of rules becomes large it's
more efficient to pursue a "use your judgement" approach. However,
since this is only 3 cases I'd prefer to wait to see if it grows.
The concern with this approach is that for newer people, contributors,
etc it's h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35521749
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35521750
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12781/
---
If you
Github user sryza closed the pull request at:
https://github.com/apache/incubator-spark/pull/555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/611#discussion_r9875482
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/ZooKeeperLeaderElectionAgent.scala
---
@@ -18,105 +18,73 @@
package org.apache.spa
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/618#discussion_r9875739
--- Diff: docs/scala-programming-guide.md ---
@@ -17,12 +17,12 @@ This guide shows each of these features and walks
through some samples. It assum
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/618#issuecomment-35529528
LGTM too, apologies for not catching this issue earlier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/332#discussion_r9875857
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/332#discussion_r9875875
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/332#discussion_r9875896
--- Diff: core/src/main/scala/org/apache/spark/network/Connection.scala ---
@@ -431,6 +466,7 @@ private[spark] class ReceivingConnection(channel_ :
Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/618#issuecomment-35530603
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
I
Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/618#issuecomment-35530650
thank you very much for your comments @pwendell @aarondav
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Patrick, I sympathize with your sensibility here, and at face value,
there's very little daylight between (a) a rule comprising small set of
enumerated items and (b) a guideline followed by the same set as examples.
My suggestion had a non-obvious tl;dr thesis behind it, so allow me to show
my car
Without bikeshedding this too much ... It is likely incorrect (not wrong) -
and rules like this potentially cause things to slip through.
Explicit return type strictly specifies what is being exposed (think in
face of impl change - createFoo changes in future from Foo to Foo1 or Foo2)
.. being con
One slight concern regarding primitive types -- in particular, Ints and
Longs can have semantic differences when it comes to overflow, so it's
often good to know what type of variable you're returning. Perhaps it is
sufficient to say that Int is the "default" numeric type, and that other
types shou
Mridul,
Can you be more specific in the createFoo example?
def myFunc = createFoo
is disallowed in my guideline. It is invoking a function createFoo, not the
constructor of Foo.
On Wed, Feb 19, 2014 at 10:39 AM, Mridul Muralidharan wrote:
> Without bikeshedding this too much ... It is likel
I found Haskell's convention of including type signatures as documentation
to be worthwhile.
http://www.haskell.org/haskellwiki/Type_signatures_as_good_style
I'd support a guideline to include type signatures where they're unclear
but would prefer to leave it quite vague. In my experience, the l
My initial mail had it listed, adding more details here since I assume I am
missing something or not being clear - please note, this is just
illustrative and my scala knowledge is bad :-) (I am trying to draw
parallels from mistakes in java world)
def createFoo = new Foo()
To
def createFoo = new
I agree, makes sense.
Please note I was referring only to exposed user api in my comments - not
other code !
Regards,
Mridul
On Feb 20, 2014 12:15 AM, "Andrew Ash" wrote:
> I found Haskell's convention of including type signatures as documentation
> to be worthwhile.
>
> http://www.haskell.org/h
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/332#discussion_r9878293
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user mengxr commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35535759
DOI links are "permanent" so we don't need to worry about the link becoming
invalid again. People will do a search and find the pdf easily if they don't
have acce
Github user fommil commented on the pull request:
https://github.com/apache/incubator-spark/pull/575#issuecomment-35546981
@mengxr consider this message to be proof that jniloader is distributed
under the Apache license. I'll update the build files next time I need a code
change. If y
Github user fommil commented on the pull request:
https://github.com/apache/incubator-spark/pull/575#issuecomment-35547276
@srowen "The LGPL is ineligible primarily due to the restrictions it places
on larger works, violating the third license criterion. Therefore,
LGPL-licensed works
Github user fommil commented on the pull request:
https://github.com/apache/incubator-spark/pull/575#issuecomment-35548061
@srowen I've asked the question. I'm interested to see the response:
https://issues.apache.org/jira/browse/LEGAL-192
---
If your project is set up for it, you ca
Github user mengxr commented on the pull request:
https://github.com/apache/incubator-spark/pull/575#issuecomment-35557645
@fommil Thanks a lot! The license JIRA is also interesting to follow ~ :)
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/618#issuecomment-35567163
Thanks guys I put this in master and 0.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9889925
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,105 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9890048
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,115 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9890019
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,115 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user CodingCat commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35568283
@mengxr good point, I agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please to
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9890236
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,105 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-spark/pull/618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this featur
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9890431
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,105 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user colorant commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35570472
ah, so the sleep removed ;) and the synchronization block is already there,
is it ok?
---
If your project is set up for it, you can reply to this email and hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35572288
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35572287
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/615#discussion_r9891770
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -165,19 +165,20 @@ class SparkContext(
jars.foreach(addJar)
}
Github user sryza commented on the pull request:
https://github.com/apache/incubator-spark/pull/615#issuecomment-35572922
Will this nomenclature make sense in the context of yarn-standalone mode,
where spark-class is used, but the driver is run inside an application master
on the clus
Github user CrazyJvm commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35575435
take "permanent valid url" into consideration, change url from yahoo to
ieee. thx @mengxr .
http://dx.doi.org/10.1109/ICDM.2008.22
---
If your project is s
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35579235
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12782/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/611#issuecomment-35579234
Build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post y
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/192#issuecomment-35580209
See SPARK-1110... I took down some notes there relevant to this:
https://spark-project.atlassian.net/browse/SPARK-1110
---
If your project is set up for it,
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/615#issuecomment-35581271
@sryza - I don't think this is relevant to the YARN codepath. AFAIK YARN
doesn't use the ./spark-class script to launch the YARN application master
(which embed
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/615#issuecomment-35581371
It looks like there is a separate variable called `amMemory` that deals
with this in YARN. The command for launching that JVM gets set-up in:
common
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/468#issuecomment-35582252
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/468#issuecomment-35582253
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post yo
Github user ScrapCodes commented on the pull request:
https://github.com/apache/incubator-spark/pull/539#issuecomment-35586860
Hey Matei,
I feel this is better than before in overall. There is one thing I was not
very sure about is putting a couple of implicits in JavaPairRDD
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/468#issuecomment-35587410
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12783/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/468#issuecomment-35587409
Build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post y
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/585#discussion_r9895285
--- Diff: project/MimaBuild.scala ---
@@ -0,0 +1,105 @@
+import com.typesafe.tools.mima.plugin.MimaKeys.{binaryIssueFilters,
previousArtifact}
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/619#issuecomment-35592012
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post
Github user ScrapCodes commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35593470
Hey @pwendell, Not sure how, cleared ivy and m2 for spark but it is not
possible to get rid of these. I am trying it with jenkins once, since you could
remove
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-spark/pull/619
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35594451
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/585#issuecomment-35594452
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user MLnick commented on the pull request:
https://github.com/apache/incubator-spark/pull/500#issuecomment-35595951
@rxin can we look at merging this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, pl
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/500#issuecomment-35596136
Merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your resp
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-spark/pull/500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this featur
93 matches
Mail list logo
