Review Request 54325: SQOOP-3051 Remove all old profiles, configurations from build.xml and ivy.xml and consolidate them to a single working one

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54325/ --- Review request for Sqoop, Attila Szabo and Szabolcs Vasas. Bugs: SQOOP-3051

[jira] [Updated] (SQOOP-3051) Remove/delete obsolete profiles from build.xml

[ https://issues.apache.org/jira/browse/SQOOP-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Szonyi updated SQOOP-3051: --- Attachment: SQOOP-3051.patch > Remove/delete obsolete profiles from build.xml > --

[jira] [Updated] (SQOOP-3051) Remove/delete obsolete profiles from build.xml

[ https://issues.apache.org/jira/browse/SQOOP-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Szonyi updated SQOOP-3051: --- Attachment: (was: SQOOP-3051.patch) > Remove/delete obsolete profiles from build.xml > ---

[jira] [Commented] (SQOOP-2925) Modify ivy settings to work from the local ivy cache, thus making ant compile much faster

[ https://issues.apache.org/jira/browse/SQOOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716601#comment-15716601 ] Hudson commented on SQOOP-2925: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop23 #1277 (

[jira] [Commented] (SQOOP-2925) Modify ivy settings to work from the local ivy cache, thus making ant compile much faster

[ https://issues.apache.org/jira/browse/SQOOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716583#comment-15716583 ] Hudson commented on SQOOP-2925: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop20 #1075 (

[jira] [Commented] (SQOOP-2925) Modify ivy settings to work from the local ivy cache, thus making ant compile much faster

[ https://issues.apache.org/jira/browse/SQOOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716563#comment-15716563 ] Hudson commented on SQOOP-2925: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1081

[jira] [Commented] (SQOOP-2925) Modify ivy settings to work from the local ivy cache, thus making ant compile much faster

[ https://issues.apache.org/jira/browse/SQOOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716523#comment-15716523 ] Hudson commented on SQOOP-2925: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop100 #1040

[jira] [Commented] (SQOOP-2925) Modify ivy settings to work from the local ivy cache, thus making ant compile much faster

[ https://issues.apache.org/jira/browse/SQOOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716218#comment-15716218 ] ASF subversion and git services commented on SQOOP-2925: Commit c3

Re: Review Request 47110: Proposed changes to make the local ivy resolver faster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47110/ --- (Updated Dec. 2, 2016, 8:41 p.m.) Review request for Sqoop. Bugs: SQOOP-2925

Re: Review Request 47110: Proposed changes to make the local ivy resolver faster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47110/#review157817 --- Ship it! Hi Attila, This is a super helpful patch, makes my iv

[jira] [Updated] (SQOOP-3052) Introduce Maven/Gradle/etc. based build for Sqoop to make it more developer friendly / open

[ https://issues.apache.org/jira/browse/SQOOP-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Szonyi updated SQOOP-3052: --- Assignee: (was: Anna Szonyi) > Introduce Maven/Gradle/etc. based build for Sqoop to make it more d

[jira] [Commented] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715425#comment-15715425 ] Hudson commented on SQOOP-3053: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop23 #1276 (

[jira] [Updated] (SQOOP-3051) Remove/delete obsolete profiles from build.xml

[ https://issues.apache.org/jira/browse/SQOOP-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Szonyi updated SQOOP-3051: --- Attachment: SQOOP-3051.patch > Remove/delete obsolete profiles from build.xml > --

[jira] [Commented] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715414#comment-15715414 ] Hudson commented on SQOOP-3053: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop20 #1074 (

[jira] [Commented] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715404#comment-15715404 ] Hudson commented on SQOOP-3053: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1080

[jira] [Commented] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715355#comment-15715355 ] Hudson commented on SQOOP-3053: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop100 #1039

[jira] [Updated] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Szabo updated SQOOP-3053: Fix Version/s: 1.4.7 > Create a cmd line argument for sqoop.throwOnError and use it through > Sqoop

[jira] [Commented] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715346#comment-15715346 ] ASF subversion and git services commented on SQOOP-3053: Commit 0e

[jira] [Commented] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715342#comment-15715342 ] Attila Szabo commented on SQOOP-3053: - Thank you [~BoglarkaEgyed] for your contributio

[jira] [Updated] (SQOOP-3053) Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

[ https://issues.apache.org/jira/browse/SQOOP-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boglarka Egyed updated SQOOP-3053: -- Attachment: SQOOP-3053.patch > Create a cmd line argument for sqoop.throwOnError and use it thro

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/ --- (Updated Dec. 2, 2016, 2:29 p.m.) Review request for Sqoop and Attila Szabo.

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

> On Dec. 2, 2016, 2:24 p.m., Attila Szabo wrote: > > src/java/org/apache/sqoop/tool/BaseSqoopTool.java, line 296 > > > > > > One last comment: > > Please fix the indentation here (remov two leading spaces). > >

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/#review157746 --- Fix it, then Ship it! src/java/org/apache/sqoop/tool/BaseSqoop

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

> On Dec. 2, 2016, 2:14 p.m., Attila Szabo wrote: > > src/java/com/cloudera/sqoop/SqoopOptions.java, lines 96-99 > > > > > > Hi Bogi, > > > > Sorry for that, but I've just spotted this: > > Could you plea

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/#review157743 --- src/java/com/cloudera/sqoop/SqoopOptions.java (lines 96 - 99)

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/#review157739 --- Ship it! Ship It! - Attila Szabo On Dec. 2, 2016, 1:15 p.m.,

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

> On Dec. 2, 2016, 11:20 a.m., Anna Szonyi wrote: > > src/java/org/apache/sqoop/Sqoop.java, line 187 > > > > > > Do you think it would make sense to extract it into a more verbose > > method, like shouldThrowOnError

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/ --- (Updated Dec. 2, 2016, 1:15 p.m.) Review request for Sqoop and Attila Szabo.

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/#review157730 --- Ship it! Ship It! - Szabolcs Vasas On Dec. 2, 2016, 10:59 a.

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

> On Dec. 2, 2016, 11:09 a.m., Attila Szabo wrote: > > src/java/org/apache/sqoop/SqoopOptions.java, lines 1037-1043 > > > > > > What about inline into something like this: > > this.throwOnError = (System.getProp

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/#review157728 --- Hi Bogi, Great changes, nice test coverage! I just have a few tin

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/#review157727 --- Fix it, then Ship it! Hi Bogi, Your change looks okay. I've ra

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

> On Dec. 1, 2016, 11:20 a.m., Szabolcs Vasas wrote: > > Hi Bogi! > > > > Thank you for your patch! I have left one minor comment for your new test > > cases and I think you could introduce a new method instead of this block: > > > > if (options.isThrowOnError()) { > >throw new RuntimeExce

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54206/ --- (Updated Dec. 2, 2016, 10:59 a.m.) Review request for Sqoop and Attila Szabo.

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

> On Nov. 30, 2016, 3:48 p.m., Erzsebet Szilagyi wrote: > > src/java/org/apache/sqoop/SqoopOptions.java, lines 1037-1038 > > > > > > Thank you for including a reasoning for developers seeing this after > > you! Ho