Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer

2018-11-13 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62523/ --- (Updated Nov. 14, 2018, 10:24 a.m.) Review request for Sqoop. Changes

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

2018-11-13 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69060/#review210519 --- Ship it! Hi Feró, Thank you for fixing all the findings, I

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

2018-11-13 Thread Boglarka Egyed
> On Nov. 9, 2018, 2:26 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/avro/AvroImportForNumericTypesTest.java > > Lines 220 (patched) > > > > > > I think these tests could be parameterized as