Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-05 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194860 --- Ship it! Ship It! - Szabolcs Vasas On Jan. 4, 2018, 2:37

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-05 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194859 --- Ship it! Hi Fero, Thanks for this fix! Your change looks

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-04 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Jan. 4, 2018, 2:37 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-04 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Jan. 4, 2018, 2:23 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-04 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194753 --- src/java/org/apache/sqoop/SqoopOptions.java Line 108 (original)

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-03 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194688 --- src/java/org/apache/sqoop/tool/ImportAllTablesTool.java Lines

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2018-01-03 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Jan. 3, 2018, 11:16 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2017-12-27 Thread Fero Szabo via Review Board
> On Dec. 22, 2017, 12:02 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/tool/ImportAllTablesTool.java > > Line 109 (original), 110 (patched) > > > > > > Now that we clone the whole SqoopOptions object

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2017-12-27 Thread Fero Szabo via Review Board
- Fero --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194418 --- On Dec. 27, 2017, 3:36 p.m., Fero Szabo wrote: > >

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2017-12-27 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Dec. 27, 2017, 3:36 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

2017-12-22 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194418 --- Hi Feró, Thank you for this patch and your thorough description!