Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review210545 --- Ship it! Hi Nguyen, Thank you very much for the update! Now

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review210541 --- Ship it! Hi Nguyen, Thank you for updating your patch, I ran

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/ --- (Updated Nov. 13, 2018, 6:18 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Sept. 10, 2018, 8:55 a.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java > > Lines 55 (patched) > > > > > > This class should be an IntegrationTest too. Sorry, my

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review209452 --- Hi Natalie, Thank you for updating your patch, sorry for the

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review209262 --- Hi Nguyen, Thank you so much for the patch update and sorry for

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

Hey Natalie, Kudos, for working on this even on the weekend! All of us appreciate the effort! Cheers, Fero On Sat, Sep 22, 2018 at 7:01 PM Nguyen Truong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/ --- (Updated Sept. 23, 2018, 2:01 a.m.) Review request for Sqoop. Changes

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208481 --- Hi Nguyen, Many thanks for updating the patch, I have one last

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208478 --- Hi Nguyen, Thank you for improving the patch! I have executed

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/ --- (Updated Sept. 8, 2018, 2:57 p.m.) Review request for Sqoop. Changes ---

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/ --- (Updated Sept. 8, 2018, 3:47 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Aug. 31, 2018, 1:24 p.m., Boglarka Egyed wrote: > > Hi Nguyen, > > > > Many thanks for taking care of this huge effort! Having well categorized > > tests is a long-awaited improvement Sqoop, it will ease the life of every > > developer. > > > > In general your change looks good to me

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Aug. 31, 2018, 1:24 p.m., Boglarka Egyed wrote: > > Hi Nguyen, > > > > Many thanks for taking care of this huge effort! Having well categorized > > tests is a long-awaited improvement Sqoop, it will ease the life of every > > developer. > > > > In general your change looks good to me

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Aug. 29, 2018, 3:39 p.m., Szabolcs Vasas wrote: > > Hi Nguyen, > > > > Thanks for submitting this, it is a great improvement! > > > > Since this is a big patch we will need some more thorough review, these are > > my suggestions after the first iteration: > > -

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Aug. 30, 2018, 12:53 p.m., Szabolcs Vasas wrote: > > Hi Nguyen, > > > > I found a couple of test classes which are not categorized, can you please > > check them? > > > > org.apache.sqoop.util.TestDirCleanupHook > > org.apache.sqoop.util.TestFileSystemUtil > >

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Aug. 29, 2018, 3:39 p.m., Szabolcs Vasas wrote: > > build.gradle > > Lines 216 (patched) > > > > > > I think this should depend on kerberizedTest task too so we cover all > > the tests which can be executed

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

> On Aug. 31, 2018, 1:24 p.m., Boglarka Egyed wrote: > > Hi Nguyen, > > > > Many thanks for taking care of this huge effort! Having well categorized > > tests is a long-awaited improvement Sqoop, it will ease the life of every > > developer. > > > > In general your change looks good to me

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208172 --- Hi Nguyen, Many thanks for taking care of this huge effort!

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208128 --- Hi Nguyen, I found a couple of test classes which are not

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208124 --- Just an FYI: I have now found another test interdependency when

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208094 --- Hi Nguyen, Thanks for submitting this, it is a great

Re: Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/#review208088 --- Ship it! Great stuff! Checked `test`, `unitTest` and

Review Request 68541: SQOOP-3104: Create test categories instead of test suites and naming conventions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68541/ --- Review request for Sqoop. Bugs: SQOOP-3104