Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-10 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review209404 --- Ship it! Ship It! - Szabolcs Vasas On Oct. 10, 2018, 11:59

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-10 Thread Boglarka Egyed
> On Oct. 10, 2018, 11:26 a.m., Szabolcs Vasas wrote: > > Hi Bogi, > > > > Thank you for improving the patch, it is much more concise now. > > I have ran the tests successfully however I noticed that when I run the > > tests without the S3 generator command the new test fails and does not get

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-10 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/ --- (Updated Oct. 10, 2018, 11:59 a.m.) Review request for Sqoop, daniel voros,

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-10 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review209401 --- Hi Bogi, Thank you for improving the patch, it is much more

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-04 Thread Boglarka Egyed
> On Oct. 4, 2018, 3:42 p.m., Fero Szabo wrote: > > Lgtm! > > > > It is interesting to see that you ran into the problem that parameterized > > tests don't support multiple dimensions! > > > > In any case, I like the tests as they are now, they are concise enough and > > descriptive enough.

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-04 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/ --- (Updated Oct. 4, 2018, 4:13 p.m.) Review request for Sqoop, daniel voros, Fero

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-10-04 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review209226 --- Ship it! Lgtm! It is interesting to see that you ran into the

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-09-24 Thread Boglarka Egyed
> On Sept. 20, 2018, 10:29 a.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableTextImport.java > > Lines 112 (patched) > > > > > > This assert could be simplified if we introduce a

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-09-24 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/ --- (Updated Sept. 24, 2018, 11:12 p.m.) Review request for Sqoop, daniel voros,

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-09-20 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review208794 --- Hi Bogi, Thank you for improving the patch, it is much more

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-09-18 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/ --- (Updated Sept. 18, 2018, 2:24 p.m.) Review request for Sqoop, daniel voros,

Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

2018-09-13 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/ --- Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas. Bugs: