Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-05-29 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/ --- (Updated May 30, 2018, 5:57 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-05-29 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/#review203969 --- Hi Chris, I did a quick review and found a couple of things,

[jira] [Commented] (SQOOP-3319) Extract code using Kite into separate classes

2018-05-29 Thread Boglarka Egyed (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493437#comment-16493437 ] Boglarka Egyed commented on SQOOP-3319: --- The [unit test

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-05-29 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/#review203967 --- Hi Chris, I had a quick glance at your patch. Mainly, it seems

[jira] [Commented] (SQOOP-3319) Extract code using Kite into separate classes

2018-05-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493230#comment-16493230 ] ASF subversion and git services commented on SQOOP-3319: Commit

Re: Review Request 67268: Extract code using Kite into separate classes

2018-05-29 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67268/#review203966 --- Ship it! Ship It! - Boglarka Egyed On May 28, 2018, 8:20

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2018-05-29 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/ --- (Updated May 29, 2018, 8:05 a.m.) Review request for Sqoop. Changes ---

[jira] [Updated] (SQOOP-3330) Sqoop --append does not work with -Dmapreduce.output.basename

2018-05-29 Thread Eric Lin (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Lin updated SQOOP-3330: Description: When adding --append to Sqoop directory import with -Dmapreduce.output.basename, all files

[jira] [Created] (SQOOP-3330) Sqoop --append does not work with -Dmapreduce.output.basename

2018-05-29 Thread Eric Lin (JIRA)
Eric Lin created SQOOP-3330: --- Summary: Sqoop --append does not work with -Dmapreduce.output.basename Key: SQOOP-3330 URL: https://issues.apache.org/jira/browse/SQOOP-3330 Project: Sqoop Issue