Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-11-03 Thread Zoltán Tóth-Czifra
On Nov. 3, 2012, 5:18 a.m., Abhijeet Gaikwad wrote: Looks good :) ant checkstyle - no errors ant test - success Thank you for your help Abhijeet! - Zoltán --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-11-02 Thread Zoltán Tóth-Czifra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7135/ --- (Updated Nov. 2, 2012, 12:32 p.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-11-02 Thread Abhijeet Gaikwad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7135/#review13075 --- Ship it! Looks good :) ant checkstyle - no errors ant test -

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-10-04 Thread Zoltán Tóth-Czifra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7135/ --- (Updated Oct. 4, 2012, 12:25 p.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-10-03 Thread Abhijeet Gaikwad
On Oct. 2, 2012, 3:45 p.m., Abhijeet Gaikwad wrote: src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java, line 342 https://reviews.apache.org/r/7135/diff/3/?file=172556#file172556line342 You meant checkpointSleepMs? Seems this is not yet resolved. - Abhijeet

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-10-02 Thread Zoltán Tóth-Czifra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7135/ --- (Updated Oct. 2, 2012, 10:08 a.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-10-02 Thread Abhijeet Gaikwad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7135/#review12099 --- Few more comments. Run ant checkstyle before you next submit the

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-10-02 Thread Zoltán Tóth-Czifra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7135/ --- (Updated Oct. 2, 2012, 4:08 p.m.) Review request for Sqoop. Changes ---

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-09-28 Thread Zoltán Tóth-Czifra
On Sept. 28, 2012, 9:59 a.m., Abhijeet Gaikwad wrote: src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java, line 329 https://reviews.apache.org/r/7135/diff/1/?file=155911#file155911line329 What happens when MYSQL_CHECKPOINT_SLEEP_KEY is greater than mapred.task.timeout?

Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

2012-09-28 Thread Abhijeet Gaikwad
On Sept. 28, 2012, 9:59 a.m., Abhijeet Gaikwad wrote: src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java, line 329 https://reviews.apache.org/r/7135/diff/1/?file=155911#file155911line329 What happens when MYSQL_CHECKPOINT_SLEEP_KEY is greater than mapred.task.timeout?