Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/#review203338
---


Ship it!




Ship It!

- Szabolcs Vasas


On May 11, 2018, 1:58 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67086/
> ---
> 
> (Updated May 11, 2018, 1:58 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3324
> https://issues.apache.org/jira/browse/SQOOP-3324
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is a missing documentation from Sqoop.
> 
> 
> Diffs
> -
> 
>   src/docs/man/hive-args.txt 438c1dc4 
>   src/docs/user/hive-args.txt 75095641 
>   src/docs/user/hive.txt f8f7c27e 
> 
> 
> Diff: https://reviews.apache.org/r/67086/diff/2/
> 
> 
> Testing
> ---
> 
> ant docs completed successfully.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[daniel voros]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/#review202947
---


Ship it!




Ship It!

- daniel voros


On May 11, 2018, 1:58 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67086/
> ---
> 
> (Updated May 11, 2018, 1:58 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3324
> https://issues.apache.org/jira/browse/SQOOP-3324
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is a missing documentation from Sqoop.
> 
> 
> Diffs
> -
> 
>   src/docs/man/hive-args.txt 438c1dc4 
>   src/docs/user/hive-args.txt 75095641 
>   src/docs/user/hive.txt f8f7c27e 
> 
> 
> Diff: https://reviews.apache.org/r/67086/diff/2/
> 
> 
> Testing
> ---
> 
> ant docs completed successfully.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[Fero Szabo via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/
---

(Updated May 11, 2018, 1:58 p.m.)


Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.


Bugs: SQOOP-3324
https://issues.apache.org/jira/browse/SQOOP-3324


Repository: sqoop-trunk


Description
---

This is a missing documentation from Sqoop.


Diffs (updated)
-

  src/docs/man/hive-args.txt 438c1dc4 
  src/docs/user/hive-args.txt 75095641 
  src/docs/user/hive.txt f8f7c27e 


Diff: https://reviews.apache.org/r/67086/diff/2/

Changes: https://reviews.apache.org/r/67086/diff/1-2/


Testing
---

ant docs completed successfully.


Thanks,

Fero Szabo

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[Fero Szabo via Review Board]

> On May 11, 2018, 11:32 a.m., daniel voros wrote:
> > src/docs/user/hive.txt
> > Lines 115 (patched)
> > 
> >
> > nit: I'm sure we have this wrong elsewhere too, but I think we should 
> > say "switch" or "option" instead of "flag" if it takes an argument.
> 
> Boglarka Egyed wrote:
> +1 for using "option" here.

Then I have no other options! :)


- Fero


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/#review202923
---


On May 11, 2018, 11:10 a.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67086/
> ---
> 
> (Updated May 11, 2018, 11:10 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3324
> https://issues.apache.org/jira/browse/SQOOP-3324
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is a missing documentation from Sqoop.
> 
> 
> Diffs
> -
> 
>   src/docs/man/hive-args.txt 438c1dc4 
>   src/docs/user/hive-args.txt 75095641 
>   src/docs/user/hive.txt f8f7c27e 
> 
> 
> Diff: https://reviews.apache.org/r/67086/diff/1/
> 
> 
> Testing
> ---
> 
> ant docs completed successfully.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[Boglarka Egyed]

> On May 11, 2018, 11:32 a.m., daniel voros wrote:
> > src/docs/user/hive.txt
> > Lines 115 (patched)
> > 
> >
> > nit: I'm sure we have this wrong elsewhere too, but I think we should 
> > say "switch" or "option" instead of "flag" if it takes an argument.

+1 for using "option" here.


- Boglarka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/#review202923
---


On May 11, 2018, 11:10 a.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67086/
> ---
> 
> (Updated May 11, 2018, 11:10 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3324
> https://issues.apache.org/jira/browse/SQOOP-3324
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is a missing documentation from Sqoop.
> 
> 
> Diffs
> -
> 
>   src/docs/man/hive-args.txt 438c1dc4 
>   src/docs/user/hive-args.txt 75095641 
>   src/docs/user/hive.txt f8f7c27e 
> 
> 
> Diff: https://reviews.apache.org/r/67086/diff/1/
> 
> 
> Testing
> ---
> 
> ant docs completed successfully.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[daniel voros]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/#review202923
---



Thanks a lot for al these documentation issues! Are you going thru the list of 
command line options to see if they're all documented?


src/docs/user/hive.txt
Lines 115 (patched)


nit: I'm sure we have this wrong elsewhere too, but I think we should say 
"switch" or "option" instead of "flag" if it takes an argument.



src/docs/user/hive.txt
Lines 127 (patched)


I think this command misses "import --hive-import" after "sqoop".


- daniel voros


On May 11, 2018, 11:10 a.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67086/
> ---
> 
> (Updated May 11, 2018, 11:10 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3324
> https://issues.apache.org/jira/browse/SQOOP-3324
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is a missing documentation from Sqoop.
> 
> 
> Diffs
> -
> 
>   src/docs/man/hive-args.txt 438c1dc4 
>   src/docs/user/hive-args.txt 75095641 
>   src/docs/user/hive.txt f8f7c27e 
> 
> 
> Diff: https://reviews.apache.org/r/67086/diff/1/
> 
> 
> Testing
> ---
> 
> ant docs completed successfully.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

[Fero Szabo via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/
---

Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.


Bugs: SQOOP-3324
https://issues.apache.org/jira/browse/SQOOP-3324


Repository: sqoop-trunk


Description
---

This is a missing documentation from Sqoop.


Diffs
-

  src/docs/man/hive-args.txt 438c1dc4 
  src/docs/user/hive-args.txt 75095641 
  src/docs/user/hive.txt f8f7c27e 


Diff: https://reviews.apache.org/r/67086/diff/1/


Testing
---

ant docs completed successfully.


Thanks,

Fero Szabo