Re: Review Request 68516: Improve third party tests to be able to execute them in a single JVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68516/#review208019 --- Ship it! Unit and S3 tests passed for me as well. (Except for the ones with Kerberos, of course.) - Fero Szabo On Aug. 27, 2018, 12:38 p.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68516/ > --- > > (Updated Aug. 27, 2018, 12:38 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3367 > https://issues.apache.org/jira/browse/SQOOP-3367 > > > Repository: sqoop-trunk > > > Description > --- > > The goal of this JIRA is to improve the third party tests to be able to > execute them in a single JVM. See the parent JIRA for the details. > > > Diffs > - > > src/java/org/apache/sqoop/hive/HiveImport.java 5da00a740 > src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java a8072b92a > src/test/org/apache/sqoop/manager/oracle/SystemImportTest.java e0a0462c3 > src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java ad2f10a07 > src/test/org/apache/sqoop/testutil/LobAvroImportTestCase.java 20d6151ba > testdata/hive/scripts/customDelimImport.q a27396947 > testdata/hive/scripts/dateImport.q 476d4310c > testdata/hive/scripts/decimalMapImport.q 8f05d585d > testdata/hive/scripts/failingImport.q 476d4310c > testdata/hive/scripts/fieldWithNewlineImport.q c6c9ebdaa > testdata/hive/scripts/fieldWithNewlineReplacementImport.q a4b8a5992 > testdata/hive/scripts/incrementalHiveAppend10.q 383c7b4aa > testdata/hive/scripts/incrementalHiveAppend20.q 383c7b4aa > testdata/hive/scripts/incrementalHiveAppendEmpty.q 383c7b4aa > testdata/hive/scripts/normalImport.q 34d6ac1ea > testdata/hive/scripts/numericImport.q bef7c715e > testdata/hive/scripts/partitionImport.q 68ce7c1bb > > > Diff: https://reviews.apache.org/r/68516/diff/1/ > > > Testing > --- > > Ran unit and third party tests. > Note that if you want to run the tests with forkEvery set to 0, you have to > disable the kereberized test cases first as I did here: > https://github.com/szvasas/sqoop/commit/d9ba8a511ed0bad119e105b97f4725ea0951 > Setting the forkEvery to 0: > https://github.com/szvasas/sqoop/commit/6332c2959bafb95e83c2d9a4030ba432cfd4c640 > > > Thanks, > > Szabolcs Vasas > >
Re: Review Request 68516: Improve third party tests to be able to execute them in a single JVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68516/ --- (Updated Aug. 27, 2018, 12:38 p.m.) Review request for Sqoop. Bugs: SQOOP-3367 https://issues.apache.org/jira/browse/SQOOP-3367 Repository: sqoop-trunk Description --- The goal of this JIRA is to improve the third party tests to be able to execute them in a single JVM. See the parent JIRA for the details. Diffs - src/java/org/apache/sqoop/hive/HiveImport.java 5da00a740 src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java a8072b92a src/test/org/apache/sqoop/manager/oracle/SystemImportTest.java e0a0462c3 src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java ad2f10a07 src/test/org/apache/sqoop/testutil/LobAvroImportTestCase.java 20d6151ba testdata/hive/scripts/customDelimImport.q a27396947 testdata/hive/scripts/dateImport.q 476d4310c testdata/hive/scripts/decimalMapImport.q 8f05d585d testdata/hive/scripts/failingImport.q 476d4310c testdata/hive/scripts/fieldWithNewlineImport.q c6c9ebdaa testdata/hive/scripts/fieldWithNewlineReplacementImport.q a4b8a5992 testdata/hive/scripts/incrementalHiveAppend10.q 383c7b4aa testdata/hive/scripts/incrementalHiveAppend20.q 383c7b4aa testdata/hive/scripts/incrementalHiveAppendEmpty.q 383c7b4aa testdata/hive/scripts/normalImport.q 34d6ac1ea testdata/hive/scripts/numericImport.q bef7c715e testdata/hive/scripts/partitionImport.q 68ce7c1bb Diff: https://reviews.apache.org/r/68516/diff/1/ Testing (updated) --- Ran unit and third party tests. Note that if you want to run the tests with forkEvery set to 0, you have to disable the kereberized test cases first as I did here: https://github.com/szvasas/sqoop/commit/d9ba8a511ed0bad119e105b97f4725ea0951 Setting the forkEvery to 0: https://github.com/szvasas/sqoop/commit/6332c2959bafb95e83c2d9a4030ba432cfd4c640 Thanks, Szabolcs Vasas
Re: Review Request 68516: Improve third party tests to be able to execute them in a single JVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68516/#review207965 --- Ship it! Hi Szabolcs, I ran the unit tests and third party tests and everything ran fine. Thank you for your contribution. Best, Nguyen - Nguyen Truong On Aug. 27, 2018, 8:46 a.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68516/ > --- > > (Updated Aug. 27, 2018, 8:46 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3367 > https://issues.apache.org/jira/browse/SQOOP-3367 > > > Repository: sqoop-trunk > > > Description > --- > > The goal of this JIRA is to improve the third party tests to be able to > execute them in a single JVM. See the parent JIRA for the details. > > > Diffs > - > > src/java/org/apache/sqoop/hive/HiveImport.java 5da00a740 > src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java a8072b92a > src/test/org/apache/sqoop/manager/oracle/SystemImportTest.java e0a0462c3 > src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java ad2f10a07 > src/test/org/apache/sqoop/testutil/LobAvroImportTestCase.java 20d6151ba > testdata/hive/scripts/customDelimImport.q a27396947 > testdata/hive/scripts/dateImport.q 476d4310c > testdata/hive/scripts/decimalMapImport.q 8f05d585d > testdata/hive/scripts/failingImport.q 476d4310c > testdata/hive/scripts/fieldWithNewlineImport.q c6c9ebdaa > testdata/hive/scripts/fieldWithNewlineReplacementImport.q a4b8a5992 > testdata/hive/scripts/incrementalHiveAppend10.q 383c7b4aa > testdata/hive/scripts/incrementalHiveAppend20.q 383c7b4aa > testdata/hive/scripts/incrementalHiveAppendEmpty.q 383c7b4aa > testdata/hive/scripts/normalImport.q 34d6ac1ea > testdata/hive/scripts/numericImport.q bef7c715e > testdata/hive/scripts/partitionImport.q 68ce7c1bb > > > Diff: https://reviews.apache.org/r/68516/diff/1/ > > > Testing > --- > > Ran unit and third party tests. > > > Thanks, > > Szabolcs Vasas > >
Review Request 68516: Improve third party tests to be able to execute them in a single JVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68516/ --- Review request for Sqoop. Bugs: SQOOP-3367 https://issues.apache.org/jira/browse/SQOOP-3367 Repository: sqoop-trunk Description --- The goal of this JIRA is to improve the third party tests to be able to execute them in a single JVM. See the parent JIRA for the details. Diffs - src/java/org/apache/sqoop/hive/HiveImport.java 5da00a740 src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java a8072b92a src/test/org/apache/sqoop/manager/oracle/SystemImportTest.java e0a0462c3 src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java ad2f10a07 src/test/org/apache/sqoop/testutil/LobAvroImportTestCase.java 20d6151ba testdata/hive/scripts/customDelimImport.q a27396947 testdata/hive/scripts/dateImport.q 476d4310c testdata/hive/scripts/decimalMapImport.q 8f05d585d testdata/hive/scripts/failingImport.q 476d4310c testdata/hive/scripts/fieldWithNewlineImport.q c6c9ebdaa testdata/hive/scripts/fieldWithNewlineReplacementImport.q a4b8a5992 testdata/hive/scripts/incrementalHiveAppend10.q 383c7b4aa testdata/hive/scripts/incrementalHiveAppend20.q 383c7b4aa testdata/hive/scripts/incrementalHiveAppendEmpty.q 383c7b4aa testdata/hive/scripts/normalImport.q 34d6ac1ea testdata/hive/scripts/numericImport.q bef7c715e testdata/hive/scripts/partitionImport.q 68ce7c1bb Diff: https://reviews.apache.org/r/68516/diff/1/ Testing --- Ran unit and third party tests. Thanks, Szabolcs Vasas
