Re: Review Request 69434: SQOOP-3410: Test S3 import with fs.s3a.security.credential.provider.path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69434/#review210832 --- Ship it! Lgtm - Fero Szabo On Nov. 22, 2018, 4:06 p.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69434/ > --- > > (Updated Nov. 22, 2018, 4:06 p.m.) > > > Review request for Sqoop, Fero Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3410 > https://issues.apache.org/jira/browse/SQOOP-3410 > > > Repository: sqoop-trunk > > > Description > --- > > Based on > https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/index.html#Configure_the_hadoop.security.credential.provider.path_property > property fs.s3a.security.credential.provider.path can also be used for > passing the location of the credential store. This should be also tested and > documented. > > > Diffs > - > > src/docs/user/s3.txt 6ff828c497e0711a2394f768ed5d61ecaf9ec273 > src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java > 4e79f0ae252969c4a426d1ff69072695eb37b7a6 > src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java > dca3195b8051048c5c7c2fb3bf30774e9d19eda8 > src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java > e1d7cbda2c65aa59a89715adff52b85fb3730477 > > > Diff: https://reviews.apache.org/r/69434/diff/1/ > > > Testing > --- > > ant clean test > ./gradlew -Ds3.bucket.url= > -Ds3.generator.command= s3Test --tests > TestS3ImportWithHadoopCredProvider > > ant clean docs > ./gradlew docs > > > Thanks, > > Boglarka Egyed > >
Re: Review Request 69434: SQOOP-3410: Test S3 import with fs.s3a.security.credential.provider.path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69434/#review210824 --- Ship it! Hi Bogi, Thanks for covering this additional property, ship it! - Szabolcs Vasas On Nov. 22, 2018, 4:06 p.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69434/ > --- > > (Updated Nov. 22, 2018, 4:06 p.m.) > > > Review request for Sqoop, Fero Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3410 > https://issues.apache.org/jira/browse/SQOOP-3410 > > > Repository: sqoop-trunk > > > Description > --- > > Based on > https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/index.html#Configure_the_hadoop.security.credential.provider.path_property > property fs.s3a.security.credential.provider.path can also be used for > passing the location of the credential store. This should be also tested and > documented. > > > Diffs > - > > src/docs/user/s3.txt 6ff828c497e0711a2394f768ed5d61ecaf9ec273 > src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java > 4e79f0ae252969c4a426d1ff69072695eb37b7a6 > src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java > dca3195b8051048c5c7c2fb3bf30774e9d19eda8 > src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java > e1d7cbda2c65aa59a89715adff52b85fb3730477 > > > Diff: https://reviews.apache.org/r/69434/diff/1/ > > > Testing > --- > > ant clean test > ./gradlew -Ds3.bucket.url= > -Ds3.generator.command= s3Test --tests > TestS3ImportWithHadoopCredProvider > > ant clean docs > ./gradlew docs > > > Thanks, > > Boglarka Egyed > >
Review Request 69434: SQOOP-3410: Test S3 import with fs.s3a.security.credential.provider.path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69434/ --- Review request for Sqoop, Fero Szabo and Szabolcs Vasas. Bugs: SQOOP-3410 https://issues.apache.org/jira/browse/SQOOP-3410 Repository: sqoop-trunk Description --- Based on https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/index.html#Configure_the_hadoop.security.credential.provider.path_property property fs.s3a.security.credential.provider.path can also be used for passing the location of the credential store. This should be also tested and documented. Diffs - src/docs/user/s3.txt 6ff828c497e0711a2394f768ed5d61ecaf9ec273 src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java 4e79f0ae252969c4a426d1ff69072695eb37b7a6 src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java dca3195b8051048c5c7c2fb3bf30774e9d19eda8 src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java e1d7cbda2c65aa59a89715adff52b85fb3730477 Diff: https://reviews.apache.org/r/69434/diff/1/ Testing --- ant clean test ./gradlew -Ds3.bucket.url= -Ds3.generator.command= s3Test --tests TestS3ImportWithHadoopCredProvider ant clean docs ./gradlew docs Thanks, Boglarka Egyed
