Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/268#issuecomment-65763659
Thanks Tedï¼
Yes, we need a fine-grained lock at âsynchronrized connect() â.
I see you changed it to use schedule Runnable, it may cause deadlock,
[
https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235282#comment-14235282
]
ASF GitHub Bot commented on STORM-329:
--
Github user clockfly commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/337#issuecomment-6573
+1 this change itself looks good, but there are a number of issues with the
metrics.log file. I filed STORM-584 to address them.
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235564#comment-14235564
]
ASF GitHub Bot commented on STORM-584:
--
Github user revans2 commented on the pull
Robert Joseph Evans created STORM-584:
-
Summary: LoggingMetricsConsumer metrics.log file is shared by
multiple topologies.
Key: STORM-584
URL: https://issues.apache.org/jira/browse/STORM-584
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/336#issuecomment-65800546
@shanyu This is a ton of code. Do you have a JIRA for this? Do you have a
design document of some sort describing how this works?
---
If your project is set up for it,
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/332#issuecomment-65801126
The change looks fine to me +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/330#issuecomment-65801181
@ptgoetz any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/STORM-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235576#comment-14235576
]
ASF GitHub Bot commented on STORM-567:
--
Github user revans2 commented on the pull
GitHub user Lewuathe opened a pull request:
https://github.com/apache/storm/pull/338
[STORM-391] KafkaSpout to await for the topic
KafkaSpout is waiting for creation of target topic.
Curator keeps watching existence of topic path for a given time length.
You can merge this pull
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235577#comment-14235577
]
ASF GitHub Bot commented on STORM-391:
--
GitHub user Lewuathe opened a pull request:
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/314#issuecomment-65801449
With pull #330 now up, I will wait for it to go in, and then rebase my
changes on top of it.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/STORM-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235579#comment-14235579
]
ASF GitHub Bot commented on STORM-557:
--
Github user revans2 commented on the pull
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65802076
Why not use kafka api for performing such check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235583#comment-14235583
]
ASF GitHub Bot commented on STORM-391:
--
Github user lazyval commented on the pull
Github user Lewuathe commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65803225
@lazyval I think all nodes in storm clusters should refer its own state
through zookeeper. This is important to keep consistency of cluster. Sorry I
don't know such
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235595#comment-14235595
]
ASF GitHub Bot commented on STORM-391:
--
Github user Lewuathe commented on the pull
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235622#comment-14235622
]
ASF GitHub Bot commented on STORM-391:
--
Github user harshach commented on the pull
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65808799
@Lewuathe there is [similar method in kafka's
ZkUtils](https://github.com/apache/kafka/blob/0.8/core/src/main/scala/kafka/utils/ZkUtils.scala#L749-L755)
---
If your
Frantz Mazoyer created STORM-585:
Summary: Performance issue in none grouping
Key: STORM-585
URL: https://issues.apache.org/jira/browse/STORM-585
Project: Apache Storm
Issue Type: Bug
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65817741
@lazyval we shouldn't be using getAllTopics method instead rely on
exceptions thrown by the Kafka api.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235715#comment-14235715
]
ASF GitHub Bot commented on STORM-391:
--
Github user harshach commented on the pull
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235717#comment-14235717
]
ASF GitHub Bot commented on STORM-391:
--
Github user lazyval commented on the pull
[
https://issues.apache.org/jira/browse/STORM-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frantz Mazoyer updated STORM-585:
-
Description:
In function mk-grouper, target-tasks is originally a ^List
It then becomes a
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/337#issuecomment-65819939
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/333#issuecomment-65822858
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Parth Brahmbhatt created STORM-586:
--
Summary: Trident kafka spout fails instead of updating offset when
kafka offset is out of range.
Key: STORM-586
URL: https://issues.apache.org/jira/browse/STORM-586
[
https://issues.apache.org/jira/browse/STORM-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236274#comment-14236274
]
ASF GitHub Bot commented on STORM-586:
--
GitHub user Parth-Brahmbhatt opened a pull
Github user Lewuathe commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65881172
@harshach Catching UnknownTopicOrPartitionException consumes some network
bandwidth, doesn't it? It will check whether kafka server has the topic or not.
Watching ZK
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236520#comment-14236520
]
Jungtaek Lim commented on STORM-544:
Since [~ptgoetz] pushed document files to master
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-544:
---
Description:
Actually I've mailed this to Storm Dev mailing list, but nobody cares so I
repost it to
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-544:
---
Description:
Actually I've mailed this to Storm Dev mailing list, but nobody cares so I
repost it to
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-544:
---
Description:
Actually I've mailed this to Storm Dev mailing list, but nobody cares so I
repost it to
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim reassigned STORM-544:
--
Assignee: Jungtaek Lim (was: P. Taylor Goetz)
Some documents from website are outdated
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65884958
@Lewuathe its just one kafka request right? . KafkaSpout makes one request
if that request fails than you'll get a exception and if that exception happens
to be
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236581#comment-14236581
]
ASF GitHub Bot commented on STORM-391:
--
Github user harshach commented on the pull
Parth Brahmbhatt created STORM-587:
--
Summary: trident transactional state in zk should be namespaced
with topology id
Key: STORM-587
URL: https://issues.apache.org/jira/browse/STORM-587
Project:
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65885304
I agree with Sriharsha. The current code relies too heavily on kafka's
internal zk metadata storage. This is fragile, we should not be depending
directly on any
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236587#comment-14236587
]
ASF GitHub Bot commented on STORM-391:
--
Github user Parth-Brahmbhatt commented on the
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/339#discussion_r21414360
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/UpdateOffsetException.java ---
@@ -17,6 +17,9 @@
*/
package storm.kafka;
-public
[
https://issues.apache.org/jira/browse/STORM-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236589#comment-14236589
]
ASF GitHub Bot commented on STORM-586:
--
Github user harshach commented on a diff in
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/340
STORM-544 Fix outdated documents
1.
storm-starter link from all (or most? I don't know) documents refers to
https://github.com/nathanmarz/storm-starter, it should be
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236591#comment-14236591
]
ASF GitHub Bot commented on STORM-544:
--
GitHub user HeartSaVioR opened a pull request:
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236592#comment-14236592
]
Sriharsha Chintalapani commented on STORM-544:
--
[~kabhwan] can we keep that as
[
https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236594#comment-14236594
]
Jungtaek Lim commented on STORM-544:
[~sriharsha] Oh, I didn't think about it. Then we
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-65885963
Could anybody check/review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236595#comment-14236595
]
Jungtaek Lim commented on STORM-487:
Could anybody check/review this?
Remove
[
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236596#comment-14236596
]
ASF GitHub Bot commented on STORM-487:
--
Github user HeartSaVioR commented on the pull
Github user Lewuathe commented on the pull request:
https://github.com/apache/storm/pull/338#issuecomment-65887266
@harshach I understand what you mean. I'll modify codes to check the
existence of topic with Kafka api. But I have a question for confirmation.
Anyway we have to access
[
https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236634#comment-14236634
]
ASF GitHub Bot commented on STORM-391:
--
Github user Lewuathe commented on the pull
[
https://issues.apache.org/jira/browse/STORM-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shanyu zhao updated STORM-583:
--
Attachment: Storm-EventHubsDesign.docx
Attached a simple design document.
Add spout and bolt
51 matches
Mail list logo
