[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262013#comment-14262013 ] ASF GitHub Bot commented on STORM-609: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68428398 @HeartSaVioR , please help to review the JedisCommands usage in Trident implementation. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261992#comment-14261992 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68426972 @dashengju Thanks for applying unification on Jedis / JedisCluster into Trident implementation! --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-595) storm-hdfs can only work with sequence files that use Writables

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261481#comment-14261481 ] ASF GitHub Bot commented on STORM-595: -- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-595) storm-hdfs can only work with sequence files that use Writables

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261482#comment-14261482 ] ASF GitHub Bot commented on STORM-595: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-595 Added support for serialization to S...

2014-12-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/351#issuecomment-68396802 @mikert Thanks for the patch pushed to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] storm pull request: STORM-595 Added support for serialization to S...

2014-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-610) worker-launcher doesn't check return value of fts_close while setting up a directory

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261208#comment-14261208 ] ASF GitHub Bot commented on STORM-610: -- Github user harshach commented on the pull req

[GitHub] storm pull request: [STORM-610] Check the return value of fts_clos...

2014-12-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/366#issuecomment-68369531 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-596) "topology.receiver.buffer.size" has no effect

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261062#comment-14261062 ] ASF GitHub Bot commented on STORM-596: -- Github user Lewuathe commented on the pull req

[GitHub] storm pull request: STORM-596: remove config topology.receiver.buf...

2014-12-30 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/storm/pull/363#issuecomment-68353816 @caofangkun I think correct behaviour is restricting the max size of `batched` ArrayList within given `max-buffer-size` . But if you mean this parameter is not necessary

[jira] [Commented] (STORM-595) storm-hdfs can only work with sequence files that use Writables

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261029#comment-14261029 ] ASF GitHub Bot commented on STORM-595: -- Github user mikert commented on the pull reque

[GitHub] storm pull request: STORM-595 Added support for serialization to S...

2014-12-30 Thread mikert
Github user mikert commented on the pull request: https://github.com/apache/storm/pull/351#issuecomment-68350181 So what are the odds that this'll get merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260993#comment-14260993 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68347429 @dashengju Thanks! And you can see we don't need to separate Jedis implementation and JedisCluster implementation when we use JedisCommands. Hope this helps. :D ---

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260978#comment-14260978 ] ASF GitHub Bot commented on STORM-609: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68346400 @HeartSaVioR I have merged your PR, thanks. And I have added Apache licenses to all files. I have found JedisCommands interface suitable for trident state, and

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260940#comment-14260940 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68341375 @dashengju It would be great to move test codes to src/test/java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260932#comment-14260932 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68340267 I've implemented basic Redis bolt which supports JedisCommands (interface for single key commands). Please take a look if you're interested in. https://git