[jira] [Updated] (STORM-618) Add spoutconfig option to make kafka spout process messages at most once.

2015-01-08 Thread Adrian Seungjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/STORM-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Seungjin Lee updated STORM-618: -- Issue Type: Improvement (was: Bug) Add spoutconfig option to make kafka spout process

[jira] [Updated] (STORM-243) Record version and revision information in builds

2015-01-08 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-243: - Attachment: ui.png Record version and revision information in builds

[jira] [Commented] (STORM-618) Add spoutconfig option to make kafka spout process messages at most once.

2015-01-08 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270330#comment-14270330 ] Jungtaek Lim commented on STORM-618: I also don't think it's a bug because users can

[jira] [Commented] (STORM-618) Kafka spout should provide optional way to implement at-most once semantic

2015-01-08 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270321#comment-14270321 ] Sriharsha Chintalapani commented on STORM-618: -- [~sweetest_sj] I don't think

[jira] [Closed] (STORM-378) SleepSpoutWaitStrategy.emptyEmit should use the variable streak

2015-01-08 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun closed STORM-378. Resolution: Not a Problem Assignee: caofangkun SleepSpoutWaitStrategy.emptyEmit should use the

[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...

2015-01-08 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (STORM-243) Record version and revision information in builds

2015-01-08 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-243: - Description: The effect shown below, For Subversion project : $ storm version Storm

[GitHub] storm pull request: STORM-243,Record version and revision informat...

2015-01-08 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69279498 Hi @revans2 Thank you for your patience and advices. I have fixed the bugs as you mentioned above unit tests passed. Please have a review once more.

[jira] [Assigned] (STORM-553) Provide standard Java/Clojure Code Style Formatter profiles

2015-01-08 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun reassigned STORM-553: Assignee: caofangkun Provide standard Java/Clojure Code Style Formatter profiles

[jira] [Created] (STORM-619) add supervisor page to show workers running detail informations

2015-01-08 Thread caofangkun (JIRA)
caofangkun created STORM-619: Summary: add supervisor page to show workers running detail informations Key: STORM-619 URL: https://issues.apache.org/jira/browse/STORM-619 Project: Apache Storm

[GitHub] storm pull request: STORM-473:Provide BASH script like: storm.sh s...

2015-01-08 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-473) Provide BASH script (storm.sh)

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270419#comment-14270419 ] ASF GitHub Bot commented on STORM-473: -- Github user caofangkun closed the pull request

[jira] [Closed] (STORM-535) setup 'java.library.path' for native-storm code if necessary

2015-01-08 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun closed STORM-535. Resolution: Won't Fix Assignee: caofangkun setup 'java.library.path' for native-storm code if

[jira] [Commented] (STORM-243) Record version and revision information in builds

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270129#comment-14270129 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull

[GitHub] storm pull request: STORM-243,Record version and revision informat...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69259821 @caofangkun It looks like you have fixed most of the issues here. Do you think it is ready for me to review? --- If your project is set up for it, you can reply to this

[jira] [Created] (STORM-618) should provide optional way to implement at-most once semantic

2015-01-08 Thread Adrian Seungjin Lee (JIRA)
Adrian Seungjin Lee created STORM-618: - Summary: should provide optional way to implement at-most once semantic Key: STORM-618 URL: https://issues.apache.org/jira/browse/STORM-618 Project: Apache

[jira] [Updated] (STORM-618) Add spoutconfig option to make kafka spout process messages at most once.

2015-01-08 Thread Adrian Seungjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/STORM-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Seungjin Lee updated STORM-618: -- Summary: Add spoutconfig option to make kafka spout process messages at most once.

[GitHub] storm pull request: STORM-618 : Add spoutconfig option to make kaf...

2015-01-08 Thread sweetest
GitHub user sweetest opened a pull request: https://github.com/apache/storm/pull/376 STORM-618 : Add spoutconfig option to make kafka spout process messages at most once. Closes [STORM-618](https://issues.apache.org/jira/browse/STORM-618) While it's nice for kafka spout

[jira] [Commented] (STORM-618) Add spoutconfig option to make kafka spout process messages at most once.

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270331#comment-14270331 ] ASF GitHub Bot commented on STORM-618: -- GitHub user sweetest opened a pull request:

[jira] [Commented] (STORM-378) SleepSpoutWaitStrategy.emptyEmit should use the variable streak

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270412#comment-14270412 ] ASF GitHub Bot commented on STORM-378: -- Github user caofangkun closed the pull request

[jira] [Commented] (STORM-535) setup 'java.library.path' for native-storm code if necessary

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270425#comment-14270425 ] ASF GitHub Bot commented on STORM-535: -- Github user caofangkun closed the pull request

[GitHub] storm pull request: Merge pull request #2 from apache/master

2015-01-08 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/375 Merge pull request #2 from apache/master Merge from trunk to caofangkun You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: Merge pull request #2 from apache/master

2015-01-08 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/354#discussion_r22665893 --- Diff: docs/documentation/nimbus-ha-design.md --- @@ -0,0 +1,223 @@ +#Highly Available Nimbus design proposal +##Problem Statement: +Currently

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69217277 I am also rather nervous about clients talking directly to zookeeper to know where nimbus is. Zookeeper is really the scaling bottle neck in storm storm right now, and

[jira] [Commented] (STORM-411) Extend file uploads to support more distributed cache like semantics

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269586#comment-14269586 ] ASF GitHub Bot commented on STORM-411: -- Github user revans2 commented on the pull

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69206035 Oh and it looks like the bittorrent code is not even used right now, so I don't wee a reason to have it as a dependency. --- If your project is set up for it, you can

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69206813 @revans2 I did not do anything special it works on my machine but I just checked and the default JVM on my machine is 1.7. I removed the bit torrent code as I

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69210667 @revans2 I also removed one unused import that was causing the 1.7 requirement, I tried locally with 1.6 and it worked fine. Let me know if you run into some

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69212412 From reading through the design document, my initial impressions are that we are coupling the Nimbus fail over and leader election too closely to having a persistent

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69205183 OK I want to start off by saying that I am getting some compilation errors. First the code now requires the use of java 7 to compile. I don't think it is that big of a

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/354#discussion_r22675607 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -31,6 +32,7 @@ (defmulti download-storm-code cluster-mode) (defmulti

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2015-01-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/254#discussion_r22678017 --- Diff: external/storm-kafka/src/jvm/storm/kafka/ExponentialBackoffMsgRetryManager.java --- @@ -0,0 +1,154 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2015-01-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/254#discussion_r22678403 --- Diff: external/storm-kafka/src/jvm/storm/kafka/ExponentialBackoffMsgRetryManager.java --- @@ -0,0 +1,154 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/254#issuecomment-69242628 @rick-kilgore I did a pass through the code and it looks good to me. I have two comments that I see as nice to have, but I don't think would block this from going in.

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/354#discussion_r22675836 --- Diff: storm-core/test/clj/backtype/storm/security/auth/nimbus_auth_test.clj --- @@ -48,6 +48,7 @@ nimbus-server (ThriftServer. (:daemon-conf

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/354#discussion_r22676097 --- Diff: storm-core/src/clj/backtype/storm/cluster.clj --- @@ -309,6 +324,16 @@ (swap! assignment-version-callback assoc storm-id

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/354#discussion_r22676169 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -31,6 +32,7 @@ (defmulti download-storm-code cluster-mode)

[GitHub] storm pull request: use boolean to replace some?, backtype.storm.u...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/285#issuecomment-69243249 @taojoe any update on this? If I don't hear from you soon, I'll probably just file a JIRA myself for this. --- If your project is set up for it, you can reply to this

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/354#discussion_r22675158 --- Diff: storm-core/src/clj/backtype/storm/cluster.clj --- @@ -309,6 +324,16 @@ (swap! assignment-version-callback assoc storm-id callback))

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-01-08 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-69236886 I have done a quick read through the code, but nothing too deep. I think a lot of the work seems fine, but I really would like to see a much better split between the

[jira] [Commented] (STORM-495) Add delayed retries to KafkaSpout

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269980#comment-14269980 ] ASF GitHub Bot commented on STORM-495: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-495) Add delayed retries to KafkaSpout

2015-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269986#comment-14269986 ] ASF GitHub Bot commented on STORM-495: -- Github user revans2 commented on a diff in the