[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Linyuxin (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632299#comment-14632299 ] Linyuxin commented on STORM-950: Looks beautiful and hierarchical. But the font may be too

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632285#comment-14632285 ] ASF GitHub Bot commented on STORM-643: -- Github user 2new commented on the pull request

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread 2new
Github user 2new commented on the pull request: https://github.com/apache/storm/pull/642#issuecomment-122485021 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[jira] [Commented] (STORM-918) Storm CLI could validate arguments/print usage

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632274#comment-14632274 ] ASF GitHub Bot commented on STORM-918: -- Github user bourneagain commented on the pull

[GitHub] storm pull request: STORM-918 Storm CLI could validate arguments/p...

2015-07-17 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/632#issuecomment-122483857 Thanks for the comments, I understand the implication now and have changed the code accordingly. --- If your project is set up for it, you can reply to this email a

[jira] [Commented] (STORM-139) hashCode does not work for byte[]

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632256#comment-14632256 ] ASF GitHub Bot commented on STORM-139: -- Github user harshach commented on the pull req

[GitHub] storm pull request: [STORM-139] Correctly hash byte array tuple va...

2015-07-17 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/641#issuecomment-122480198 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632254#comment-14632254 ] ASF GitHub Bot commented on STORM-643: -- Github user harshach commented on the pull req

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/642#issuecomment-122480095 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632253#comment-14632253 ] ASF GitHub Bot commented on STORM-643: -- Github user vesense commented on the pull requ

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122479965 @HeartSaVioR I have created a new PR(https://github.com/apache/storm/pull/642) based on master branch. Could you take a look? Thx. --- If your project is set up for

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632249#comment-14632249 ] ASF GitHub Bot commented on STORM-643: -- GitHub user vesense opened a pull request:

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/642 [STORM-643] KafkaUtils repeatedly fetches messages whose offset is out of range STORM-643 fixing based on master branch You can merge this pull request into a Git repository by running: $ git p

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122479359 @HeartSaVioR Yeah, you are right. We can reproduce the issue with 0.10.x branch too. And I will make a new PR based on master branch. --- If your project is set up for i

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632242#comment-14632242 ] ASF GitHub Bot commented on STORM-643: -- Github user vesense commented on the pull requ

[jira] [Resolved] (STORM-67) Provide API for spouts to know how many pending messages there are

2015-07-17 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-67. --- Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~shyamrajendran] for great work. I merged this to

[jira] [Commented] (STORM-67) Provide API for spouts to know how many pending messages there are

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632233#comment-14632233 ] ASF GitHub Bot commented on STORM-67: - Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122468927 @vesense Though I don't know about storm-kafka deeply, seems like ExponentialBackoffMsgRetryManager doesn't care about it. It just delays retrying failed tuples, and

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632217#comment-14632217 ] ASF GitHub Bot commented on STORM-643: -- Github user HeartSaVioR commented on the pull

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632215#comment-14632215 ] ASF GitHub Bot commented on STORM-643: -- Github user vesense commented on the pull requ

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122467741 Thanks for reminding. Yes, I'm working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632211#comment-14632211 ] ASF GitHub Bot commented on STORM-643: -- Github user vesense closed the pull request at

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense closed the pull request at: https://github.com/apache/storm/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632210#comment-14632210 ] ASF GitHub Bot commented on STORM-643: -- Github user vesense commented on the pull requ

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-122466082 Will do. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[jira] [Resolved] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-643. Resolution: Fixed Fix Version/s: 0.9.6 Thanks [~vesense], I merged into 0.9.x-branch. Please

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632191#comment-14632191 ] ASF GitHub Bot commented on STORM-643: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-122464841 @vesense I merged #635 to 0.9.x-branch. Could you close the PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Updated] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x)

2015-07-17 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-643: --- Summary: KafkaUtils repeatedly fetches messages whose offset is out of range (for 0.9.x) (was: KafkaUt

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632190#comment-14632190 ] ASF GitHub Bot commented on STORM-643: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-643) KafkaUtils repeatedly fetches messages whose offset is out of range

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632176#comment-14632176 ] ASF GitHub Bot commented on STORM-643: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-643] KafkaUtils repeatedly fetches mess...

2015-07-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/635#issuecomment-122462058 +1. I'll merge it. Please note that we're considering only 0.9.x now, so we should try to reproduce and fix from 0.10.x and master later. --- If your projec

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632149#comment-14632149 ] Sriharsha Chintalapani commented on STORM-950: -- [~kabhwan] Thanks for the feed

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632129#comment-14632129 ] Jungtaek Lim commented on STORM-950: Looks beautiful on my laptop! Personally I really

[jira] [Commented] (STORM-139) hashCode does not work for byte[]

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632121#comment-14632121 ] ASF GitHub Bot commented on STORM-139: -- GitHub user d2r reopened a pull request:

[GitHub] storm pull request: [STORM-139] Correctly hash byte array tuple va...

2015-07-17 Thread d2r
GitHub user d2r reopened a pull request: https://github.com/apache/storm/pull/641 [STORM-139] Correctly hash byte array tuple values * Unit test for correctness is included * The following tests showed no discernible difference in latency or throughput: * word_count, last

[jira] [Commented] (STORM-139) hashCode does not work for byte[]

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632115#comment-14632115 ] ASF GitHub Bot commented on STORM-139: -- Github user d2r closed the pull request at:

[GitHub] storm pull request: [STORM-139] Correctly hash byte array tuple va...

2015-07-17 Thread d2r
Github user d2r closed the pull request at: https://github.com/apache/storm/pull/641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Commented] (STORM-139) hashCode does not work for byte[]

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632090#comment-14632090 ] ASF GitHub Bot commented on STORM-139: -- GitHub user d2r opened a pull request: ht

[GitHub] storm pull request: [STORM-139] Correctly hash byte array tuple va...

2015-07-17 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/641 [STORM-139] Correctly hash byte array tuple values * Unit test for correctness is included * The following tests showed no discernible difference in latency or throughput: * word_count, last 10

[jira] [Created] (STORM-951) Storm Hive connector not aborting transactions incase of failures

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created STORM-951: Summary: Storm Hive connector not aborting transactions incase of failures Key: STORM-951 URL: https://issues.apache.org/jira/browse/STORM-951 Project

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632000#comment-14632000 ] Sriharsha Chintalapani commented on STORM-950: -- Thanks [~dagit]. I'll try to r

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631999#comment-14631999 ] Sriharsha Chintalapani commented on STORM-950: -- Thanks [~dagit]. I'll try to r

[jira] [Issue Comment Deleted] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-950: - Comment: was deleted (was: Thanks [~dagit]. I'll try to reproduce this. If its poss

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631987#comment-14631987 ] P. Taylor Goetz commented on STORM-950: --- Keep in mind this is just a preview at the m

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631972#comment-14631972 ] Derek Dagit commented on STORM-950: --- When the header bar attaches to the top of the windo

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631964#comment-14631964 ] Derek Dagit commented on STORM-950: --- OK, just saw it happen for another user with a simil

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631961#comment-14631961 ] Derek Dagit commented on STORM-950: --- Yeah, its FF 39.0 on OSX. The size of the canvas is

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631935#comment-14631935 ] Sriharsha Chintalapani commented on STORM-950: -- [~dagit] I tried it on Firefox

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631929#comment-14631929 ] Derek Dagit commented on STORM-950: --- This is beautiful, nice work! If I scroll to the bo

[jira] [Created] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created STORM-950: Summary: Apache Storm website redesign Key: STORM-950 URL: https://issues.apache.org/jira/browse/STORM-950 Project: Apache Storm Issue Type:

[jira] [Commented] (STORM-950) Apache Storm website redesign

2015-07-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631915#comment-14631915 ] Sriharsha Chintalapani commented on STORM-950: -- Here is staging website with u

[jira] [Created] (STORM-949) On the topology summary UI page, last shown error should have the time and date

2015-07-17 Thread Reza Farivar (JIRA)
Reza Farivar created STORM-949: -- Summary: On the topology summary UI page, last shown error should have the time and date Key: STORM-949 URL: https://issues.apache.org/jira/browse/STORM-949 Project: Apac

[GitHub] storm pull request: fix the dismatch between doc and code for read...

2015-07-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/570#issuecomment-122277257 @chuanlei Thanks, it's my pleasure. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-728) UI: Component Page "Spout stats" table has Emitted and Transferred in each other's column

2015-07-17 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631277#comment-14631277 ] Derek Dagit commented on STORM-728: --- > I changed affect version and fix version from JIR

[jira] [Created] (STORM-948) "topology.max.spout.pending" submitted with the component configuration is ignored

2015-07-17 Thread Eugene Tolmachev (JIRA)
Eugene Tolmachev created STORM-948: -- Summary: "topology.max.spout.pending" submitted with the component configuration is ignored Key: STORM-948 URL: https://issues.apache.org/jira/browse/STORM-948 Pr

[GitHub] storm pull request: fix the dismatch between doc and code for read...

2015-07-17 Thread chuanlei
Github user chuanlei commented on the pull request: https://github.com/apache/storm/pull/570#issuecomment-122240118 @revans2 @HeartSaVioR Thank you very much. @HeartSaVioR has helped me a lot in the Storm topic. You can really patient and friendly to newbie to Storm. --- If your

[jira] [Commented] (STORM-947) replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo `

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631157#comment-14631157 ] ASF GitHub Bot commented on STORM-947: -- Github user chuanlei commented on the pull req

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

2015-07-17 Thread chuanlei
Github user chuanlei commented on the pull request: https://github.com/apache/storm/pull/640#issuecomment-122239340 I think it is good since `ExecutorDetails` does not take more information. And this change make Storm code more concise. But I'm sure whether `ExecutorDetails` i

[jira] [Commented] (STORM-947) replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo `

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631154#comment-14631154 ] ASF GitHub Bot commented on STORM-947: -- Github user chuanlei commented on a diff in th

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

2015-07-17 Thread chuanlei
Github user chuanlei commented on a diff in the pull request: https://github.com/apache/storm/pull/640#discussion_r34878435 --- Diff: storm-core/src/clj/backtype/storm/scheduler/DefaultScheduler.clj --- @@ -18,7 +18,7 @@ (:require [backtype.storm.scheduler.EvenScheduler :as

[jira] [Commented] (STORM-947) replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo `

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631110#comment-14631110 ] ASF GitHub Bot commented on STORM-947: -- GitHub user caofangkun opened a pull request:

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

2015-07-17 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/640 STORM-947: replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo ` You can merge this pull request into a Git repository by running: $ git pu

[jira] [Created] (STORM-947) replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo `

2015-07-17 Thread caofangkun (JIRA)
caofangkun created STORM-947: Summary: replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo ` Key: STORM-947 URL: https://issues.apache.org/jira/browse/STORM-947

[jira] [Commented] (STORM-946) We should remove Closed Client form cached-node+port->socket in worker

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630919#comment-14630919 ] ASF GitHub Bot commented on STORM-946: -- Github user tedxia commented on the pull reque

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-17 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122206400 Will you have a look at the description of this pull request, it describe the situation. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-946) We should remove Closed Client form cached-node+port->socket in worker

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630903#comment-14630903 ] ASF GitHub Bot commented on STORM-946: -- Github user caofangkun commented on the pull r

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-17 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122203636 @tedxia I could only find two situations ( am I right?) will change ```client.status``` to ```closed``` by call ```(.close socket)```. and do not need reconnect

[jira] [Commented] (STORM-946) We should remove Closed Client form cached-node+port->socket in worker

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630883#comment-14630883 ] ASF GitHub Bot commented on STORM-946: -- Github user tedxia commented on the pull reque

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-17 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122199889 Yes we should use client.status(), and I am sorry for this error, I will add new patch to fix this. @caofangkun Will you have a look at Client, once client's stat