Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/894#discussion_r45434875
--- Diff: storm-core/src/jvm/backtype/storm/spout/RawScheme.java ---
@@ -18,11 +18,13 @@
package backtype.storm.spout;
import
[
https://issues.apache.org/jira/browse/STORM-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015195#comment-15015195
]
ASF GitHub Bot commented on STORM-1220:
---
Github user arunmahadevan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015227#comment-15015227
]
ASF GitHub Bot commented on STORM-1220:
---
Github user harshach commented on a diff in the pull
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/894#discussion_r45436089
--- Diff: storm-core/src/jvm/backtype/storm/spout/RawScheme.java ---
@@ -18,11 +18,13 @@
package backtype.storm.spout;
import
[
https://issues.apache.org/jira/browse/STORM-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015237#comment-15015237
]
ASF GitHub Bot commented on STORM-1220:
---
Github user arunmahadevan commented on a diff in the pull
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/894#discussion_r45436425
--- Diff: storm-core/src/jvm/backtype/storm/spout/RawScheme.java ---
@@ -18,11 +18,13 @@
package backtype.storm.spout;
import
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158283901
Utils.java
* In general, the new methods we are adding here might be better off
somewhere in the blobstore package.
* Check indentation of changed code. I see
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015250#comment-15015250
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015257#comment-15015257
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on the pull request:
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158284600
ConfigValidation.java
```
480/**
481 * Validate topology.map config
482 */
483 public static class
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158284724
Revert changes to ConfigValidationAnnotations.java; it's only white-space
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015260#comment-15015260
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45429107
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/STORM-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015047#comment-15015047
]
ASF GitHub Bot commented on STORM-1009:
---
Github user wuchong commented on the pull request:
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/882#issuecomment-158260200
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158264627
```
396 struct ReadableBlobMeta {
397 1: required SettableBlobMeta settable;
398 //This is some indication of a version of a BLOB. The only guarantee
is
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015088#comment-15015088
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015131#comment-15015131
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015130#comment-15015130
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015155#comment-15015155
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/STORM-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roshan Naik updated STORM-1199:
---
Attachment: HDFSSpoutforStorm v2.pdf
Uploading the v2 of the design and requirements doc.
In this
Github user lujinhong commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158262273
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45432068
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,306 @@
+/**
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015112#comment-15015112
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45432533
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015124#comment-15015124
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45432555
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015141#comment-15015141
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015138#comment-15015138
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45432871
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,306 @@
+/**
+ * Licensed to the Apache Software Foundation
Very well stated Juntaek.
I should also point out that there's nothing stopping the JStorm team from
releasing new versions of JStorm, or adding new features. But you would have to
be careful to note that any such release is "JStorm" and not "Apache Storm."
And any such release cannot be
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015176#comment-15015176
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on the pull request:
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/894#discussion_r45435067
--- Diff: external/storm-kafka/src/jvm/storm/kafka/StringScheme.java ---
@@ -20,21 +20,23 @@
import backtype.storm.spout.Scheme;
import
[
https://issues.apache.org/jira/browse/STORM-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015233#comment-15015233
]
ASF GitHub Bot commented on STORM-1155:
---
Github user hustfxj commented on a diff in the pull
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/849#discussion_r45436295
--- Diff: storm-core/src/clj/backtype/storm/command/healthcheck.clj ---
@@ -0,0 +1,88 @@
+;; Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/STORM-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015254#comment-15015254
]
ASF GitHub Bot commented on STORM-1222:
---
GitHub user haohui opened a pull request:
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/890#issuecomment-158106182
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013777#comment-15013777
]
ASF GitHub Bot commented on STORM-1217:
---
Github user kishorvpatil commented on the pull request:
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/891#issuecomment-158109736
@revans2 Yes, it is inserted into the generated HTML. Since javadoc isn't
part of the source release, it probably only needs to be added to the LICENSE
for the binary
[
https://issues.apache.org/jira/browse/STORM-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013803#comment-15013803
]
ASF GitHub Bot commented on STORM-1218:
---
Github user ptgoetz commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013812#comment-15013812
]
ASF GitHub Bot commented on STORM-1075:
---
Github user fhussonnois commented on a diff in the pull
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015058#comment-15015058
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015158#comment-15015158
]
ASF GitHub Bot commented on STORM-876:
--
Github user d2r commented on a diff in the pull request:
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45433430
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,306 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158273465
LocalizedResourceRetentionSet.java
```
140 public boolean equals(Object other) {
141 return this == other;
142 }
```
Object is the
[
https://issues.apache.org/jira/browse/STORM-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015197#comment-15015197
]
ASF GitHub Bot commented on STORM-1220:
---
Github user arunmahadevan commented on a diff in the pull
GitHub user haohui opened a pull request:
https://github.com/apache/storm/pull/896
STORM-1222. Support Kafka as external tables in StormSQL
This PR adds the support of Kafka as external tables in StormSQL.
You can merge this pull request into a Git repository by running:
$ git
Haohui Mai created STORM-1222:
-
Summary: Support Kafka as external tables in StormSQL
Key: STORM-1222
URL: https://issues.apache.org/jira/browse/STORM-1222
Project: Apache Storm
Issue Type: New
Hi,
We are developing application where after some days of topology run, we get
continuous warning messages
2015-11-20 05:05:42.226 s.k.KafkaUtils [WARN] Got fetch request with offset out
of range: [7238824446]
2015-11-20 05:05:42.229 s.k.t.TridentKafkaEmitter [WARN] OffsetOutOfRange:
I am not such of fan of simply substituting the Apache Storm clojure core with
the JStorm java core either. Don't get me wrong, I would very much like to
merge the two projects together and build a stronger community but we cannot
just hastily rush this process. Like others have said the
[
https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015338#comment-15015338
]
ASF GitHub Bot commented on STORM-1167:
---
Github user asfgit closed the pull request at:
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/855#issuecomment-158301323
Thanks @arunmahadevan merged into trunk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015339#comment-15015339
]
ASF GitHub Bot commented on STORM-1167:
---
Github user harshach commented on the pull request:
Longda,
"2.1 Copy modules from JStorm, one module from one module
> 2.2 The sequence is extern
> modules/client/utils/nimbus/supervisor/drpc/worker & task/web ui/others"
Are you suggesting we just copy the Jstorm code in place of clojure? If
so thats not going to work. There might be some code
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated STORM-1214:
--
Description:
There are a few idiosyncrasies in the Trident API that can sometimes trip
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/887#issuecomment-158094151
@ptgoetz Yes you are correct about the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/STORM-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013712#comment-15013712
]
ASF GitHub Bot commented on STORM-1213:
---
Github user revans2 commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013747#comment-15013747
]
ASF GitHub Bot commented on STORM-1202:
---
Github user kishorvpatil commented on the pull request:
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/889#issuecomment-158100747
I am a +1. I like this backward compatibility feature for smooth migration
to package renaming. The changes look good to me. I ran some tests with
topology jar
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158080086
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ashnazg commented on the pull request:
https://github.com/apache/storm/pull/833#issuecomment-158080714
Is there a trick to mailing dev@storm.apache.org? I've only gotten one out
of six emails to show up there. I'm sending them as plaintext, but I'm not a
subscriber. Is
[
https://issues.apache.org/jira/browse/STORM-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013645#comment-15013645
]
ASF GitHub Bot commented on STORM-1126:
---
Github user ashnazg commented on the pull request:
I disagree completely. You claim that JStorm is compatible with storm 1.0. I
don't believe that it is 100% compatible. There has been more then 2 years of
software development happening on both sides. Security was not done in a day,
and porting it over to JStorm is not going to happen
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-158120792
I'd like to wait for at least one more review and +1 before I merge, since
both Bobby and Kishor worked with me on the design of the system.
---
If your project is set
Arun Mahadevan created STORM-1219:
-
Summary: Fix HDFS and Hive bolt flush/acking
Key: STORM-1219
URL: https://issues.apache.org/jira/browse/STORM-1219
Project: Apache Storm
Issue Type: Bug
[
https://issues.apache.org/jira/browse/STORM-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013938#comment-15013938
]
ASF GitHub Bot commented on STORM-1219:
---
GitHub user arunmahadevan opened a pull request:
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/893
STORM-1219: Fix HDFS and Hive bolt flush/acking
HDFS and Hive bolts were setting the default tick tuple interval in the
prepare() method, which was not taking effect. Correctly set a
Github user fhussonnois commented on a diff in the pull request:
https://github.com/apache/storm/pull/827#discussion_r45364971
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/executor/AsyncExecutor.java
---
@@ -0,0 +1,152 @@
+/**
+ * Licensed
[
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013905#comment-15013905
]
ASF GitHub Bot commented on STORM-885:
--
Github user knusbaum commented on the pull request:
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/838#issuecomment-158120301
@ptgoetz
I've added a couple of sections for that stuff to the bottom of the
documentation.
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013911#comment-15013911
]
ASF GitHub Bot commented on STORM-885:
--
Github user knusbaum commented on the pull request:
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/893#issuecomment-158126017
Was the prior approach not working because getComponentConfiguration() is
called before prepare() ?
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/STORM-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013954#comment-15013954
]
ASF GitHub Bot commented on STORM-1219:
---
Github user harshach commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013955#comment-15013955
]
ASF GitHub Bot commented on STORM-1219:
---
Github user dossett commented on the pull request:
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/893#issuecomment-158125939
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/892#issuecomment-158126906
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/893#issuecomment-158126825
@dossett it appears that the component configuration is merged with the
global storm config. This happens when the topology is constructed and
serialized. The
[
https://issues.apache.org/jira/browse/STORM-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013963#comment-15013963
]
ASF GitHub Bot commented on STORM-1219:
---
Github user arunmahadevan commented on the pull request:
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/875#issuecomment-158133513
LGTM. +1. @zhuoliu please rebase the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/888
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014010#comment-15014010
]
ASF GitHub Bot commented on STORM-1198:
---
Github user kishorvpatil commented on the pull request:
[
https://issues.apache.org/jira/browse/STORM-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kishor Patil resolved STORM-1215.
-
Resolution: Fixed
Fix Version/s: 0.11.0
> Use Async Loggers to avoid locking and logging
101 - 183 of 183 matches
Mail list logo
