[GitHub] storm pull request: add hadoop-common dependency in README for sto...

Github user mazhechao commented on the pull request: https://github.com/apache/storm/pull/1436#issuecomment-220891641 @ptgoetz Will you have a look at it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: Ack late tuples in windowed mode

Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1437#issuecomment-220890249 @kosii Thanks for the patch, it looks good. Can you open a [JIRA](https://issues.apache.org/jira/browse/STORM) and update the PR title to include the JIRA ID ?

Re: Merging to Multiple Branches

maybe use scripts like https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py to automatically do so On Sat, May 21, 2016 at 1:48 AM Aaron.Dossett wrote: > Is there a best practice for merging a PR to multiple branches? I have > struggled with that in the

[jira] [Commented] (STORM-1842) Forward references in storm.thrift cause tooling issues

[ https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295893#comment-15295893 ] ASF GitHub Bot commented on STORM-1842: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1842) Forward references in storm.thrift cause tooling issues

[ https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295895#comment-15295895 ] Jungtaek Lim commented on STORM-1842: - Merged. Thanks [~ptgoetz] for reviewing and merging! > Forward

[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...

Github user HeartSaVioR closed the pull request at: https://github.com/apache/storm/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (STORM-1842) Forward references in storm.thrift cause tooling issues

[ https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295894#comment-15295894 ] ASF GitHub Bot commented on STORM-1842: --- Github user HeartSaVioR closed the pull request at:

[GitHub] storm pull request: STORM-1842 Forward references in storm.thrift ...

Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1423#issuecomment-220884435 I merged into master but github seems to not recognize merge commits as pull request. Closed via 45e62a75ce667012fa0cf74e1543784b1620d36b --- If your project

[jira] [Commented] (STORM-1842) Forward references in storm.thrift cause tooling issues

[ https://issues.apache.org/jira/browse/STORM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295890#comment-15295890 ] Jungtaek Lim commented on STORM-1842: - [~ptgoetz] Seems like you missed to merge this to master. (pull

[jira] [Commented] (STORM-1853) Deserialization issues in Utils.javaDeserialize()

[ https://issues.apache.org/jira/browse/STORM-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295889#comment-15295889 ] ASF GitHub Bot commented on STORM-1853: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1853: Replace ClassLoaderObjectInputStre...

Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1440#issuecomment-220883591 +1 I just compared ClassLoaderObjectInputStream and ObjectInputStream, and found ObjectInputStream uses latestUserDefinedLoader() which calls

[jira] [Commented] (STORM-822) Kafka Spout New Consumer API

[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295865#comment-15295865 ] ASF GitHub Bot commented on STORM-822: -- Github user jianbzhou commented on the pull request:

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-220878934 @hmcl sorry for the late reply. we have made some quick and dirty fix for above issues, I will share the new spout to you via email so you can do a quick comparison.

[jira] [Commented] (STORM-1853) Deserialization issues in Utils.javaDeserialize()

[ https://issues.apache.org/jira/browse/STORM-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295446#comment-15295446 ] ASF GitHub Bot commented on STORM-1853: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1853: Replace ClassLoaderObjectInputStre...

Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1440#issuecomment-220818443 @redsanket Test failure is unrelated. Also storm-kafka tests pass on my local box. --- If your project is set up for it, you can reply to this email and

[GitHub] storm pull request: STORM-1853: Replace ClassLoaderObjectInputStre...

Github user abhishekagarwal87 closed the pull request at: https://github.com/apache/storm/pull/1440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1853) Deserialization issues in Utils.javaDeserialize()

[ https://issues.apache.org/jira/browse/STORM-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295443#comment-15295443 ] ASF GitHub Bot commented on STORM-1853: --- Github user abhishekagarwal87 closed the pull request at:

[jira] [Commented] (STORM-1853) Deserialization issues in Utils.javaDeserialize()

[ https://issues.apache.org/jira/browse/STORM-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295444#comment-15295444 ] ASF GitHub Bot commented on STORM-1853: --- GitHub user abhishekagarwal87 reopened a pull request:

[GitHub] storm pull request: STORM-1853: Replace ClassLoaderObjectInputStre...

GitHub user abhishekagarwal87 reopened a pull request: https://github.com/apache/storm/pull/1440 STORM-1853: Replace ClassLoaderObjectInputStream with ObjectInputStream You can merge this pull request into a Git repository by running: $ git pull