[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411347#comment-15411347 ] ASF GitHub Bot commented on STORM-2016: --- Github user manuzhang commented on a diff in the pull

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73825149 --- Diff: docs/Command-line-client.md --- @@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...` Runs the main method of `class` with

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-07 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411344#comment-15411344 ] Jungtaek Lim commented on STORM-2023: - FYI: I'm talking with Julian Hyde to minimize the dependencies

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411337#comment-15411337 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 @revans2 @satishd @abhishekagarwal87 Please review again when you get some time. I'll squash the commits and go on porting this to master branch once some of us give +1 for this. Thanks

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411334#comment-15411334 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 @manuzhang Thanks for checking the details of documentation. Please leave a comment when you're done reviewing of this. Thanks! --- If your project is set up for it, you can reply to this

Re: [VOTE] Release Apache Storm 1.0.2 (rc4)

2016-08-07 Thread Harsha Chintalapani
+1 (binding) Ran a single node cluster and tried example topologies. Verified signatures on the artifcats. -Harsha On Fri, Aug 5, 2016 at 8:02 AM P. Taylor Goetz wrote: > +1 (binding) > > Ran on a 3-node cluster and verified fixes. > > -Taylor > > On Jul 26, 2016, at 4:04

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73824049 --- Diff: docs/Command-line-client.md --- @@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...` Runs the main method of `class`

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411327#comment-15411327 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on a diff in the pull

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411324#comment-15411324 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73823982 --- Diff: docs/Command-line-client.md --- @@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...` Runs the main method of `class`

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411311#comment-15411311 ] ASF GitHub Bot commented on STORM-2016: --- Github user manuzhang commented on a diff in the pull

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411308#comment-15411308 ] ASF GitHub Bot commented on STORM-2016: --- Github user manuzhang commented on a diff in the pull

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73823457 --- Diff: docs/Command-line-client.md --- @@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...` Runs the main method of `class` with

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73823437 --- Diff: docs/Command-line-client.md --- @@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...` Runs the main method of `class` with

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411304#comment-15411304 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73823221 --- Diff: bin/storm.py --- @@ -754,18 +827,24 @@ def parse_config_opts(args): elif token == "--config": global CONFFILE

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73822799 --- Diff: bin/storm.py --- @@ -754,18 +827,24 @@ def parse_config_opts(args): elif token == "--config": global CONFFILE

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411296#comment-15411296 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on a diff in the pull

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411293#comment-15411293 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73822736 --- Diff: bin/storm.py --- @@ -754,18 +827,24 @@ def parse_config_opts(args): elif token == "--config": global CONFFILE

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411281#comment-15411281 ] ASF GitHub Bot commented on STORM-2016: --- Github user manuzhang commented on a diff in the pull

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411278#comment-15411278 ] ASF GitHub Bot commented on STORM-2016: --- Github user manuzhang commented on a diff in the pull

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73822027 --- Diff: bin/storm.py --- @@ -754,18 +827,24 @@ def parse_config_opts(args): elif token == "--config": global CONFFILE

[GitHub] storm pull request #1608: STORM-2016 Topology submission improvement: suppor...

2016-08-07 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/storm/pull/1608#discussion_r73821960 --- Diff: bin/storm.py --- @@ -754,18 +827,24 @@ def parse_config_opts(args): elif token == "--config": global CONFFILE

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411272#comment-15411272 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 Porting this to master forces me to resolve huge conflict or modify the code manually. We shouldn't leave progress of Java port as it is. --- If your project is set up for it, you can reply to

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411256#comment-15411256 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 Added documentation, and replace packages to artifacts since it's clearer for its meaning. I think it's done with 1.x branch, so I'll go on porting this to master branch. --- If your

[GitHub] storm pull request #1609: fix parent version of storm-kinesis module (1.x)

2016-08-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1609: fix parent version of storm-kinesis module (1.x)

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1609 Since all builds are failing, and it's not about code itself, I'll just merge this right now. Please revert if you think it should get +1. --- If your project is set up for it, you can reply to

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411219#comment-15411219 ] ASF GitHub Bot commented on STORM-2016: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 @revans2 @satishd Addressed removing jars when topology is killed. Please note that artifacts will be not removed since it's shared among whole topologies. Since it modifies Nimbus, we

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 @abhishekagarwal87 Thanks, I took a look and your modification is simpler. Btw, I was thinking same approach, but there're some cases to handle while assembling jars (for example, the

[jira] [Commented] (STORM-2016) Topology submission improvement: support adding local jars and maven artifacts on submission

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411031#comment-15411031 ] ASF GitHub Bot commented on STORM-2016: --- Github user abhishekagarwal87 commented on the issue:

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-07 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1608 @HeartSaVioR - not sure if it will be of help, but you can also checkout https://github.com/apache/storm/pull/1296/files. I was trying out something similar. --- If your project is set

[jira] [Resolved] (STORM-1839) Kinesis Spout

2016-08-07 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1839. - Resolution: Fixed Fix Version/s: 1.1.0 2.0.0 > Kinesis Spout >

[jira] [Updated] (STORM-2021) storm-kinesis missing licenses

2016-08-07 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-2021: Affects Version/s: 1.1.0 > storm-kinesis missing licenses > -- > >

[GitHub] storm issue #1606: STORM-2020: Stop using sun internal classes. STORM-2021: ...

2016-08-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1606 STORM-2021 is also related to 1.x-branch, so I've also downmerged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-2020) Stop using sun internal classes

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410956#comment-15410956 ] ASF GitHub Bot commented on STORM-2020: --- Github user HeartSaVioR commented on the issue:

[jira] [Updated] (STORM-2021) storm-kinesis missing licenses

2016-08-07 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-2021: Fix Version/s: 1.1.0 > storm-kinesis missing licenses > -- > >

Broken Links

2016-08-07 Thread Kamal B
While going through the documents for newbie contributors, I observed the following page is outdated and most of the links are broken. http://storm.apache.org/releases/current/Message-passing-implementation.html We might think of fixing this as it has useful information for newbies. Thanks,