[GitHub] storm pull request #1728: STORM-2142 ReportErrorAndDie runs suicide function...

2016-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1728: STORM-2142 ReportErrorAndDie runs suicide function only w...

2016-10-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1728 @knusbaum Thanks for the review. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1735: STORM-203 Adding paths to default java library path

2016-10-17 Thread picadoh
Github user picadoh commented on the issue: https://github.com/apache/storm/pull/1735 yeah, makes total sense 👍 removed it from the path. thanks @knusbaum --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request #1738: STORM-2127: Storm-eventhubs should use latest amqp...

2016-10-17 Thread raviperi
GitHub user raviperi opened a pull request: https://github.com/apache/storm/pull/1738 STORM-2127: Storm-eventhubs should use latest amqp and eventhubs-client versions STORM-2127: Storm-eventhubs should use latest amqp and eventhubs-client versions You can merge this pull request

[GitHub] storm issue #1736: STORM-1446 Compile the Calcite logical plan to Storm Trid...

2016-10-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1736 @manuzhang Yes issue description just links Julian's comment and I think it's not sufficient. I'll also write up motivation and rationale to issue description. Thanks. --- If your project is

[GitHub] storm issue #1603: STORM-2012: Upgrade Kafka to 0.8.2.2

2016-10-17 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1603 Builds fine locally. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1728: STORM-2142 ReportErrorAndDie runs suicide function only w...

2016-10-17 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1728 (Nice catch, BTW) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #1728: STORM-2142 ReportErrorAndDie runs suicide function only w...

2016-10-17 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1728 +1 Looks like mistranslation. This restores the behavior of the old Clojure code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1735: STORM-203 Adding paths to default java library path

2016-10-17 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1735 /usr/lib64 is FHS standard. /usr/lib/x86_64-linux-gnu is Debian-specific. I think we should avoid setting distro-specific defaults. --- If your project is set up for it, you can reply to this

[GitHub] storm pull request #1737: STORM-2151: Update dependency on hadoop version to...

2016-10-17 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1737 STORM-2151: Update dependency on hadoop version to 2.7.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishorvpatil/incubator-storm

[GitHub] storm issue #1702: STORM-2127: Storm-eventhubs should use latest amqp and ev...

2016-10-17 Thread raviperi
Github user raviperi commented on the issue: https://github.com/apache/storm/pull/1702 @harshach Updated title as per your recommendation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1717: STORM-2127: Storm-eventhubs should use latest amqp and ev...

2016-10-17 Thread raviperi
Github user raviperi commented on the issue: https://github.com/apache/storm/pull/1717 @harshach Updated title as per your recommendation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1702: Jira 2127- Storm-eventhubs should use latest amqp and eve...

2016-10-17 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1702 @raviperi sorry for nitpick. we need the format of the title to be " STORM-2127: Storm-eventhubs should use latest amqp and eventhubs-client versions" --- If your project is set up for it, you

[GitHub] storm issue #1717: Update eventhub client dependency. Move Storm-Eventhubs d...

2016-10-17 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1717 @raviperi can you add the STORM jira number to the commit message and squash commits in both the PRs. Use the same title as the JIRA title https://issues.apache.org/jira/browse/STORM-2127 --- If

[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1

2016-10-17 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1702 @raviperi do you have JIRA filed here for this https://issues.apache.org/jira/browse/STORM/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1696: STORM-2104: More graceful handling of acked/failed tuples...

2016-10-17 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1696 @hmcl ping. Had a chance to look at this? It would be nice to get merged soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Different way used to create file path in hdfs state

2016-10-17 Thread Sachin Pasalkar
Can anyone let me know if its done purposefully? On 13/10/16, 11:08 PM, "Sachin Pasalkar" wrote: >Hi, > >I was looking HdfsState class where createOutputFile api present at line >182 is as follows > >Path path = new Path(this.fileNameFormat.getPath(),

[GitHub] storm issue #1736: STORM-1446 Compile the Calcite logical plan to Storm Trid...

2016-10-17 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/storm/pull/1736 @HeartSaVioR Thanks for the thorough explanation. I'd suggest record the motive and rationals somewhere. It's hard to follow why something exists in the first place. --- If your project is set

[GitHub] storm issue #1736: STORM-1446 Compile the Calcite logical plan to Storm Trid...

2016-10-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1736 @manuzhang Thanks for showing interest on this. Let me rearrange your questions: > Has this changed the workflow of StormSQL? No, we still rely on Trident, and nothing