[GitHub] storm pull request #1756: STORM-1278: Port org.apache.storm.daemon.worker to...

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1775: STORM-1278: Port org.apache.storm.daemon.worker to...

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1775 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1410: STORM-1778: scheme extension framework for KafkaSourcePro...

2016-11-15 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1410 @chuanlei I think this issue has been fixed by STORM-2173. Can you close this? BTW, the` CsvScheme` in STORM-2173 uses standard RFC4180 CSV parser supporting strings like `a,"b,c",d`. --- If

Re: [DISCUSS] Release Storm 1.1.0

2016-11-15 Thread P. Taylor Goetz
Thanks Xin, I added it to the 1.1.0 epic. -Taylor > On Nov 15, 2016, at 9:01 AM, Xin Wang wrote: > > STORM-2198 ( PR: https://github.com/apache/storm/pull/1773 ) fixes a bug of > storm-hdfs. Do we have a consideration to include this? > > Thanks, > Xin Wang (vesense) >

[GitHub] storm pull request #1766: [STORM-2192] Add a new IAutoCredentials plugin to ...

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1766 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] Release Storm 1.1.0

2016-11-15 Thread Aaron Niskodé-Dossett
I would be +1 for including it On Tue, Nov 15, 2016 at 8:01 AM Xin Wang wrote: STORM-2198 ( PR: https://github.com/apache/storm/pull/1773 ) fixes a bug of storm-hdfs. Do we have a consideration to include this? Thanks, Xin Wang (vesense) 2016-11-15 10:03 GMT+08:00

[GitHub] storm pull request #1779: STORM-1694: Kafka Spout Trident Implementation Usi...

2016-11-15 Thread hmcl
GitHub user hmcl opened a pull request: https://github.com/apache/storm/pull/1779 STORM-1694: Kafka Spout Trident Implementation Using New Kafka Consumer API @harshach I refactored the patch merged onto in order to compile. The changes are to remove the use of lambdas and to fix

[GitHub] storm issue #1773: STORM-2198: perform RotationAction when stopping HdfsBolt

2016-11-15 Thread dossett
Github user dossett commented on the issue: https://github.com/apache/storm/pull/1773 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1746: STORM-1607: Add MongoMapState for supporting trident's ex...

2016-11-15 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1746 Any comments are welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1778: [STORM-2082][SQL] add sql external module storm-sql-hdfs

2016-11-15 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1778 @HeartSaVioR Addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: [DISCUSS] Release Storm 1.1.0

2016-11-15 Thread Xin Wang
STORM-2198 ( PR: https://github.com/apache/storm/pull/1773 ) fixes a bug of storm-hdfs. Do we have a consideration to include this? Thanks, Xin Wang (vesense) 2016-11-15 10:03 GMT+08:00 Jungtaek Lim : > Some issues on Storm SQL are resolved but not documented yet. I'll file

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87985904 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java --- @@ -0,0 +1,152 @@ +/*

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87985832 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/jvm/org/apache/storm/sql/hdfs/HdfsDataSourcesProvider.java --- @@ -0,0 +1,132 @@ +/* +

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87976945 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java --- @@ -0,0 +1,152 @@

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87973924 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/jvm/org/apache/storm/sql/hdfs/HdfsDataSourcesProvider.java --- @@ -0,0 +1,132 @@ +/*

[GitHub] storm pull request #1777: STORM-2202 [Storm SQL] Document how to use support...

2016-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1777#discussion_r87968979 --- Diff: docs/storm-sql-reference.md --- @@ -1203,4 +1203,103 @@ and class for aggregate function is here: For now users can skip implementing

[GitHub] storm pull request #1777: STORM-2202 [Storm SQL] Document how to use support...

2016-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1777#discussion_r87968697 --- Diff: docs/storm-sql-reference.md --- @@ -1203,4 +1203,103 @@ and class for aggregate function is here: For now users can skip implementing

[GitHub] storm issue #1777: STORM-2202 [Storm SQL] Document how to use supported conn...

2016-11-15 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1777 Thanks @HeartSaVioR Just two minor comments. Others looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request #1777: STORM-2202 [Storm SQL] Document how to use support...

2016-11-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1777#discussion_r87967670 --- Diff: docs/storm-sql-reference.md --- @@ -1203,4 +1203,103 @@ and class for aggregate function is here: For now users can skip implementing `result`

[GitHub] storm pull request #1777: STORM-2202 [Storm SQL] Document how to use support...

2016-11-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1777#discussion_r87968161 --- Diff: docs/storm-sql-reference.md --- @@ -1203,4 +1203,103 @@ and class for aggregate function is here: For now users can skip implementing `result`

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1778 [STORM-2082][SQL] add sql external module storm-sql-hdfs You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-2082