[GitHub] storm issue #1784: STORM-2205: Racecondition in getting nimbus summaries whi...

2016-11-17 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1784 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1779: STORM-1694: Kafka Spout Trident Implementation Using New ...

2016-11-17 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1779 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Request write access to Storm's wiki page on Confluent

2016-11-17 Thread P. Taylor Goetz
Done. -Taylor > On Nov 17, 2016, at 1:27 PM, Hugo Da Cruz Louro > wrote: > > Hi, > > I would like to request write access to the wiki page on > Confluent. I am > currently registered but I don't have

Request write access to Storm's wiki page on Confluent

2016-11-17 Thread Hugo Da Cruz Louro
Hi, I would like to request write access to the wiki page on Confluent. I am currently registered but I don't have writing access. I have a couple of benchmarks and performance analysis that I would like to share with the

[GitHub] storm pull request #1785: [STORM-2201] Add dynamic scheduler configuration l...

2016-11-17 Thread ppoulosk
GitHub user ppoulosk opened a pull request: https://github.com/apache/storm/pull/1785 [STORM-2201] Add dynamic scheduler configuration loading. This adds an interface and two implementations, one that will load from a local file, and another that will load a config from

[GitHub] storm issue #1739: STORM-1443 [Storm SQL] Support customizing parallelism in...

2016-11-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1739 @vesense Actually I had some time to think about STORM-2147. There might be some ways to pass partition count to upstream, and easy way to do might be adding method to

[GitHub] storm issue #1739: STORM-1443 [Storm SQL] Support customizing parallelism in...

2016-11-17 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1739 @HeartSaVioR Overall looks good to me. And I have a question: Now I'm working on STORM-2147 which I think should be based on STORM-1443. Through this PR we can set the parallelism by specifying

[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...

2016-11-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1742 @vesense Thanks for reviewing, I addressed all of your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Release Storm 1.1.0

2016-11-17 Thread Satish Duggana
STORM-2205: Race condition in getting nimbus summaries while ZK connections are reconnected. This issue seems to occur in our environments and I would like this to be part of 1.1.0. Thanks, Satish. On Thu, Nov 17, 2016 at 9:36 AM, Jungtaek Lim wrote: > I have no idea on

[GitHub] storm issue #1742: STORM-2170 [Storm SQL] Add built-in socket datasource to ...

2016-11-17 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1742 Thanks @HeartSaVioR LGTM +1 Just left several comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1742: STORM-2170 [Storm SQL] Add built-in socket datasou...

2016-11-17 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1742#discussion_r88447536 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/SocketDataSourcesProvider.java --- @@ -0,0 +1,94 @@ +/**

[GitHub] storm pull request #1742: STORM-2170 [Storm SQL] Add built-in socket datasou...

2016-11-17 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1742#discussion_r88448768 --- Diff: external/sql/storm-sql-runtime/src/resources/META-INF/services/org.apache.storm.sql.runtime.DataSourcesProvider --- @@ -0,0 +1,32 @@ +# +#

[GitHub] storm pull request #1742: STORM-2170 [Storm SQL] Add built-in socket datasou...

2016-11-17 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1742#discussion_r88449665 --- Diff: external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/SocketDataSourcesProvider.java --- @@ -0,0 +1,94 @@ +/**

[GitHub] storm pull request #1784: STORM-2205: Racecondition in getting nimbus summar...

2016-11-17 Thread satishd
GitHub user satishd opened a pull request: https://github.com/apache/storm/pull/1784 STORM-2205: Racecondition in getting nimbus summaries while ZK connections are reconnected. You can merge this pull request into a Git repository by running: $ git pull