Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1808
@revans2 I would like to take a look at this before this gets merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1808
I think my only remaining nit is the spelling error in KafkaBolt. Thanks
@revans2. I am +1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91622857
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91621754
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,194 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
@srdo I think I addressed all of your review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91618249
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the
Github user csivaguru commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r91615776
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/runner/jpmml/JpmmlFactory.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91613603
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java
---
@@ -0,0 +1,194 @@
+/**
+ * Licensed to the Apache
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1781
@mkoch1 Thanks for addressing the license issue. The way you handled the
borrowed code looks fine, the important part is to leave the original copyright
statement, which you did. Thanks for pointing
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91592134
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,222 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Kafka integration using the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1808#discussion_r91592178
--- Diff: docs/storm-kafka-client.md ---
@@ -1,90 +1,222 @@
-#Storm Kafka Spout with New Kafka Consumer API
+#Storm Kafka integration using the
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1816
@hmcl I am +1 on merging. I would like to see the InputStream option added
to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1818
+1 pending travis (and the waiting period)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r91586225
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/runner/jpmml/JpmmlFactory.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1800
Okay, that last commit answered a lot of questions I had regarding
packaging. ;)
+1 I was able to build a distribution, unpack it, and run the drpc service.
---
If your project is set up
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1818
STORM-2104 1.x
1.x version of https://github.com/apache/storm/pull/1696
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2104-1.x
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1696
This looks good to me. Now that I have gone through the kafka spout code
for my other pull request I am confident in giving this a +1.
---
If your project is set up for it, you can reply to this
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1696#discussion_r91569248
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/SerializableDeserializer.java
---
@@ -0,0 +1,25 @@
+/*
+ *
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1808
Sure, that makes sense. Maybe storm-kafka-client should have been marked
unstable since it's fairly new, it's still in a phase where the kinks are being
worked out, even if the version number says
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nilday commented on the issue:
https://github.com/apache/storm/pull/1674
As soon as I find out that nimbus has been transferred to Java, I start to
work on this again. The blacklist scheduler has been working on our production
environment(Storm v1.0.1) for several months
22 matches
Mail list logo
