[GitHub] storm pull request #1829: STORM-2246: Logviewer download link has urlencodin...

2016-12-15 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/1829 STORM-2246: Logviewer download link has urlencoding on part of the URL Changed the URL format for "Download full file" link under worker logs from "download/URLENCODED()" to

[GitHub] storm pull request #1828: STORM-2245: integration-test constant compilation ...

2016-12-15 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1828 STORM-2245: integration-test constant compilation failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-2245

[GitHub] storm pull request #1746: STORM-1607: Add MongoMapState for supporting tride...

2016-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

How to debug java.nio.channels.ClosedChannelException in Storm 1.0.2

2016-12-15 Thread S G
Hi, I am using Storm 1.0.2 My configuration is quite simple: `kafka-spout` feeding to `solr-bolt` topology.workers = 2 spout.parallelism = 1 bolt.parallelism = 1 Our messages coming from kafka are large: around 100kb per message to max of 500kb per message. But I see lots of errors: Window

[GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...

2016-12-15 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1825 @srdo I'll submit a patch for that later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-12-15 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1783 @ambud I'll wait for other committers to vote for it before merging into 1.x-branch. And this may take some time. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm issue #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1816 @ptgoetz @arunmahadevan @harshach Thanks for your reviews. I believe I addressed all the comments. There is a separate commit with the comments changes. When we all agree that the patch is ready to

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736752 --- Diff: external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java --- @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736718 --- Diff: external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java --- @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736561 --- Diff: external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java --- @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736547 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java --- @@ -39,7 +39,6 @@ import

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736541 --- Diff: examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/JpmmlRunnerTestTopology.java --- @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736555 --- Diff: external/storm-pmml/src/main/java/org/apache/storm/pmml/PMMLPredictorBolt.java --- @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736543 --- Diff: examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/RawInputFromCSVSpout.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736533 --- Diff: examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/JpmmlRunnerTestTopology.java --- @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736485 --- Diff: examples/storm-pmml-examples/src/main/resources/KNIME_PMML_4.1_Examples_single_audit_logreg.xml --- @@ -0,0 +1,259 @@ + --- End diff --

[GitHub] storm pull request #1816: STORM-2223: PMMLBolt

2016-12-15 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1816#discussion_r92736455 --- Diff: external/storm-pmml/README.md --- @@ -0,0 +1,104 @@ +#Storm PMML Bolt + Storm integration to load PMML models and compute predictive scores for

[GitHub] storm issue #1359: STORM-1239: port backtype.storm.scheduler.IsolationSchedu...

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1359 @vesense @HeartSaVioR Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1136 @vesense Any update on this? It looks like pystorm/streamparse are waiting for this to be merged. cc @dan-blanchard --- If your project is set up for it, you can reply to this email and

[GitHub] storm issue #1821: STORM-2239: Handle InterruptException in new Kafka spout

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1821 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1821: STORM-2239: Handle InterruptException in new Kafka...

2016-12-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1821#discussion_r92691637 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -435,7 +435,7 @@ public void close() { }

[GitHub] storm issue #1746: STORM-1607: Add MongoMapState for supporting trident's ex...

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1746 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1821: STORM-2239: Handle InterruptException in new Kafka spout

2016-12-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1821 @ptgoetz Sure, I'll add that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1765: STORM-2190: reduce contention between submission and sche...

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1765 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1821: STORM-2239: Handle InterruptException in new Kafka spout

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1821 One minor nit: It would be helpful to construct the exceptions with a message explaining what happened. Other than that I'm +1. --- If your project is set up for it, you can reply to this

[GitHub] storm pull request #1826: STORM-2087 1.x

2016-12-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1826#discussion_r92676777 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -77,7 +77,7 @@ private KafkaSpoutStreams

[GitHub] storm issue #1818: STORM-2104 1.x

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1818 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1803: STORM-2222: Repeated NPEs thrown in nimbus if rebalance f...

2016-12-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1803 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...

2016-12-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1825 @liurenjie1024 Okay, it makes sense that having Kafka manage partitions isn't really necessary since Storm will make sure to keep spout instances running. I can't speak to how much of an overhead and

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

2016-12-15 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r92644823 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -161,13 +153,19 @@ public V get(K key, V

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

2016-12-15 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r92643170 --- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java --- @@ -52,4 +55,9 @@ * @param key the key */ V

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-12-15 Thread ambud
Github user ambud commented on the issue: https://github.com/apache/storm/pull/1783 Thank you @vesense. Could we merge the 1.x pull request as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Request to create `storm-pmml` JIRA Component field

2016-12-15 Thread Xin Wang
Hi Hugo, Added. - Xin 2016-12-14 1:30 GMT+08:00 Hugo Da Cruz Louro : > Hi, > > Can someone with permissions to create Components on JIRA please do so. It > would be helpful to tag the JIRAs associated with PMML. > > Thanks, > Hugo >

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-12-15 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1783 Thanks @ambud Squashed and merged into master. And I added you as the contributor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request #1783: STORM-2204 Adding caching capabilities in HBaseLoo...

2016-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is