[GitHub] storm issue #1843: Fix storm.py which breaks when client.jartransformer.clas...

2016-12-27 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1843 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1778 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1778: [STORM-2082][SQL] add sql external module storm-sql-hdfs

2016-12-27 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1778 Also confirmed it works. I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1778: [STORM-2082][SQL] add sql external module storm-sql-hdfs

2016-12-27 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1778 Thanks for the update. Makes sense. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

2016-12-27 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1798 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1843: Fix storm.py which breaks when client.jartransform...

2016-12-27 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1843 Fix storm.py which breaks when client.jartransformer.class is not set When such configuration is not set, `confvalue` returns `nil` in 1.x branch, and `null` in master branch. Such

[DISCUSSION] Disable integration test

2016-12-27 Thread Jungtaek Lim
Hi devs, Storm build result on Travis CI is failing most of time and it's because integration test. Due to this, we don't see Travis CI result, and miss other things like JDK compatibility (JDK 8 vs JDK 7 on between branches), or RAT failing. Unless there's no volunteer to fix integration test

[GitHub] storm pull request #1840: STORM-2256: storm-pmml breaks on java 1.7

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1840: STORM-2256: storm-pmml breaks on java 1.7

2016-12-27 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1840 Integration test fails consistently so we eventually don't see build result. We should drop integration test for now and refer Travis CI result. --- If your project is set up for it, you can

[GitHub] storm issue #1840: STORM-2256: storm-pmml breaks on java 1.7

2016-12-27 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1840 +1. Thanks for the fix. I compiled this locally, a few times... wonder how this wasn't detected :( --- If your project is set up for it, you can reply to this email and have your reply appear