[GitHub] storm pull request #1872: [STORM-2283] Fix multi threading issues in Default...

2017-01-10 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/1872 [STORM-2283] Fix multi threading issues in DefaultStateSerializer Raising a separate patch for the state issue fixed in https://github.com/apache/storm/pull/1693 You can merge this pull

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1693 @HeartSaVioR sure will raise as separate PR with the specific fix for state handling. If we plan to consider this PR for 1.x branch need to do some refactoring to make it work with

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1693 @arunmahadevan Could we have separate patch for state handling? We should push the fix for 1.x and 1.0.x branches. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1693 @HeartSaVioR have addressed the comments and fixed the issue with state handling. StatefulWordCount and StateQueryExample works fine for me locally. --- If your project is set up for it, you

[GitHub] storm issue #1871: STORM-2268: Fix integration test for Travis CI build

2017-01-10 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1871 @HeartSaVioR Thanks for reviewing. I tried cherry picking commit to other branches and it was clean. Following runs are in progress for 1.x-branch & 1.0.x-branch:

[GitHub] storm issue #1871: STORM-2268: Fix integration test for Travis CI build

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1871 Build from my fork is also succeed for integration test. +1 @raghavgautam Thanks for fixing this issue. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm issue #1871: STORM-2268: Fix integration test for Travis CI build

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1871 I'm running the build for this patch in Travis CI: https://travis-ci.org/HeartSaVioR/storm/builds/190793918 If it also passes I'll vote +1. --- If your project is set up for it, you

[GitHub] storm pull request #1867: STORM-2280 Upgrade Calcite version to 1.11.0

2017-01-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1871: STORM-2268: Fix integration test for Travis CI bui...

2017-01-10 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1871 STORM-2268: Fix integration test for Travis CI build @HeartSaVioR Can you please review ? You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/1693 One important thing to include in this API will be to allow users to be explicit about how to handle errors. I don't know if any API out there does it... so this would be unique to Storm.

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-10 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1866#discussion_r95460055 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,7 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1693 @HeartSaVioR thanks for taking time to review and provide feedback. The Redis state was working for me earlier however after rebasing with master I am seeing exceptions (triggered from kryo)

Re: [DISCUSS] Prioritizing works in progress

2017-01-10 Thread Jungtaek Lim
Updates: I reviewed PR for Stream API and think it would be good start. I would be really appreciated if some of us also participate reviewing as well. Thanks in advance. - Jungtaek Lim (HeartSaVioR) 2017년 1월 4일 (수) 오전 4:00, Hugo Da Cruz Louro 님이 작성: > Lambdas can also

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1693 I just have a look at other streaming frameworks API, and feel that this is a good start. We can still add features after this patch. I'm OK to add this for 2.0.0, but am also OK to add

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95340409 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/IBlacklistStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95340338 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/IBlacklistStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95340314 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/DefaultBlacklistStrategy.java --- @@ -0,0 +1,149 @@ +/** + * Licensed to

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95339881 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95339408 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95339494 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95338774 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-10 Thread nilday
Github user nilday commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r95338650 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1693 @arunmahadevan Btw, I'm seeing some failures with Redis state backend: StatefulWordCount and StateQueryExample. They're running fine with removing Redis state backend setting.

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r95327033 --- Diff: storm-core/src/jvm/org/apache/storm/streams/processors/Processor.java --- @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r95326909 --- Diff: storm-core/src/jvm/org/apache/storm/streams/operations/aggregators/Sum.java --- @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r95327355 --- Diff: storm-core/src/jvm/org/apache/storm/streams/processors/ProcessorContext.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

2017-01-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r95327298 --- Diff: storm-core/src/jvm/org/apache/storm/streams/processors/ProcessorContext.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-10 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1866#discussion_r95326528 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,7 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String