[GitHub] storm pull request #1808: STORM-2225: change spout config to be simpler.

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1808#discussion_r97187057 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicPartitionComparator.java --- @@ -1,16 +1,35 @@ +/* + * Licensed

Re: [DISCUSS] Adopt pull request template

Agree! My suggestions are not all or nothing. They are a set of ideas of which we can pick some. In the cases of multiple commits, I would suggest that we try to make it that all of them start with the same title STORM-XXX, such that it’s easily eye catching. That’s what lead to my suggestion

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1889#discussion_r97081027 --- Diff: storm-core/src/jvm/org/apache/storm/utils/TupleUtils.java --- @@ -40,7 +40,11 @@ public static boolean isTick(Tuple tuple) {

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1889#discussion_r97081014 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,8 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

Re: [DISCUSS] Release Storm 1.0.3

+1 from me (non-binding) 2017-01-20 5:36 GMT+01:00 Jungtaek Lim : > Hi devs, > > While we're working on issues targeted for 1.1.0, remaining issues on 1.1.0 > epic are not relevant to 1.0.3. Since we also have lots of resolved issues > for 1.0.3 [1

Re: [DISCUSS] Release Storm 1.0.3

+1 from me (non-binding) On 20 January 2017 at 04:36, Jungtaek Lim wrote: > Hi devs, > > While we're working on issues targeted for 1.1.0, remaining issues on 1.1.0 > epic are not relevant to 1.0.3. Since we also have lots of resolved issues > for 1.0.3 [1